Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2587343004: Finish implementation and tests of 5 ARIA 1.1 attributes. (Closed)

Created:
4 years ago by dmazzoni
Modified:
3 years, 10 months ago
Reviewers:
nektarios
CC:
chromium-reviews, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, kinuko+watch, caseq+blink_chromium.org, aboxhall, aboxhall+watch_chromium.org, blink-reviews-html_chromium.org, jam, dglazkov+blink, je_julie, darin-cc_chromium.org, devtools-reviews_chromium.org, blink-reviews, einbinder+watch-test-runner_chromium.org, blink-reviews-api_chromium.org, mlamouri+watch-content_chromium.org, yuzo+watch_chromium.org, dmazzoni, lushnikov+blink_chromium.org, haraken, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, nektar+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, dtseng+watch_chromium.org, mac-reviews_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Finish implementation and tests of 5 ARIA 1.1 attributes. Depends on https://codereview.chromium.org/2589273002/, which implements support for 5 sparse ARIA 1.1 attributes in Blink: aria-details aria-errormessage aria-keyshortcuts aria-modal aria-roledescription This change completes the implementation in Chrome, to the extent that they are specified, and adds tests. BUG=675994, 644766

Patch Set 1 #

Patch Set 2 : Rebase on previous change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -119 lines) Patch
M content/browser/accessibility/accessibility_tree_formatter_blink.cc View 5 chunks +56 lines, -16 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 4 chunks +18 lines, -0 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 4 chunks +18 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-activedescendant.html View 1 chunk +4 lines, -3 lines 0 comments Download
A content/test/data/accessibility/aria/aria-activedescendant-expected-blink.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-details.html View 1 chunk +12 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-details-expected-blink.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-errormessage.html View 1 chunk +12 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-errormessage-expected-blink.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-keyshortcuts.html View 1 chunk +11 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-keyshortcuts-expected-win.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-modal.html View 1 chunk +12 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-modal-expected-blink.txt View 1 chunk +7 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-modal-expected-win.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-roledescription.html View 1 chunk +11 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-roledescription-expected-blink.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-roledescription-expected-mac.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp View 1 5 chunks +18 lines, -5 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 5 chunks +7 lines, -0 lines 0 comments Download
M ui/accessibility/ax_node_data.h View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/accessibility/ax_node_data.cc View 6 chunks +102 lines, -0 lines 0 comments Download
M ui/accessibility/ax_tree_combiner.cc View 1 chunk +0 lines, -92 lines 0 comments Download

Depends on Patchset:

Issue 2589273002 Patch 1

Messages

Total messages: 6 (5 generated)
dmazzoni
4 years ago (2016-12-20 18:23:47 UTC) #3 

          

          

        


      

    
      
    
      
    
      
    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698