Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2301)

Unified Diff: content/renderer/accessibility/blink_ax_tree_source.cc

Issue 2653063002: Add 4 ARIA 1.1 attributes using new sparse attribute interface. (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-aria-1.1.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/accessibility/blink_ax_tree_source.cc
diff --git a/content/renderer/accessibility/blink_ax_tree_source.cc b/content/renderer/accessibility/blink_ax_tree_source.cc
index e6c45067b5254fef2441ef94681aa4fa88e99227..28d3f6042a85b1fb5c3113f77c9aa0e3f0bfc1f2 100644
--- a/content/renderer/accessibility/blink_ax_tree_source.cc
+++ b/content/renderer/accessibility/blink_ax_tree_source.cc
@@ -83,7 +83,17 @@ class AXContentNodeDataSparseAttributeAdapter
void addStringAttribute(blink::WebAXStringAttribute attribute,
const blink::WebString& value) override {
- NOTREACHED();
+ switch (attribute) {
+ case blink::WebAXStringAttribute::AriaKeyShortcuts:
+ // TODO(dmazzoni): implement aria-keyshortcuts. http://crbug.com/644766
+ break;
+ case blink::WebAXStringAttribute::AriaRoleDescription:
+ // TODO(dmazzoni): implement aria-roledescription.
+ // http://crbug.com/644766
+ break;
+ default:
+ NOTREACHED();
+ }
}
void addObjectAttribute(blink::WebAXObjectAttribute attribute,
@@ -92,6 +102,10 @@ class AXContentNodeDataSparseAttributeAdapter
case blink::WebAXObjectAttribute::AriaActiveDescendant:
dst_->AddIntAttribute(ui::AX_ATTR_ACTIVEDESCENDANT_ID, value.axID());
break;
+ case blink::WebAXObjectAttribute::AriaErrorMessage:
+ // TODO(dmazzoni): implement aria-errormessage.
+ // http://crbug.com/644766
+ break;
default:
NOTREACHED();
}
@@ -105,6 +119,9 @@ class AXContentNodeDataSparseAttributeAdapter
AddIntListAttributeFromWebObjects(ui::AX_ATTR_CONTROLS_IDS, value,
dst_);
break;
+ case blink::WebAXObjectVectorAttribute::AriaDetails:
+ // TODO(dmazzoni): implement aria-details. http://crbug.com/644766
+ break;
case blink::WebAXObjectVectorAttribute::AriaFlowTo:
AddIntListAttributeFromWebObjects(ui::AX_ATTR_FLOWTO_IDS, value, dst_);
break;
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-aria-1.1.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698