📰 Simplify application of partial updates on view holders

[NTP Client] Simplify application of partial updates on view holders

Removes the propagation of partial update payload from the tree
interface when binding view holders. Partial updates are now intercepted
by the Adapter and directly applied on the view holder.
This should simplify the partial vs full bind logic.

BUG=616090
Review-Url: https://codereview.chromium.org/2652953003
Cr-Commit-Position: refs/heads/master@{#445760}
Committed: https://chromium.googlesource.com/chromium/src/+/92bce5eb5a81dd0ed238621622c9ace5e2a36f7c

[dgn, 2017-01-24 14:55:00]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[dgn, 2017-01-24 14:55:15]

dgn@chromium.org changed reviewers:
+ bauerb@chromium.org

[dgn, 2017-01-24 14:55:16]

PTAL

[commit-bot: I haz the power, 2017-01-24 14:55:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 15:49:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 15:49:30]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-01-24 16:35:25]

lgtm

https://codereview.chromium.org/2652953003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
(right):

https://codereview.chromium.org/2652953003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java:153:
}
If we now have the dispatching of partial updates in one place, would it make
sense to assert if we come across an unknown payload?

[dgn, 2017-01-24 16:46:34]

thanks!

https://codereview.chromium.org/2652953003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
(right):

https://codereview.chromium.org/2652953003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java:153:
}
On 2017/01/24 16:35:25, Bernhard Bauer wrote:
> If we now have the dispatching of partial updates in one place, would it make
> sense to assert if we come across an unknown payload?

Done.

[dgn, 2017-01-24 16:46:38]

The CQ bit was checked by dgn@chromium.org

[dgn, 2017-01-24 16:46:39]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2652953003/#ps40001
(title: "fail on unknown payload")

[commit-bot: I haz the power, 2017-01-24 16:46:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 18:13:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485276398523170,
"parent_rev": "521b60491d6892113e45b522b55645c90fe39071", "commit_rev":
"92bce5eb5a81dd0ed238621622c9ace5e2a36f7c"}

[commit-bot: I haz the power, 2017-01-24 18:13:57]

Description was changed from

==========
[NTP Client] Simplify application of partial updates on view holders

Removes the propagation of partial update payload from the tree
interface when binding view holders. Partial updates are now intercepted
by the Adapter and directly applied on the view holder.
This should simplify the partial vs full bind logic.

BUG=616090
==========

to

==========
[NTP Client] Simplify application of partial updates on view holders

Removes the propagation of partial update payload from the tree
interface when binding view holders. Partial updates are now intercepted
by the Adapter and directly applied on the view holder.
This should simplify the partial vs full bind logic.

BUG=616090

Review-Url: https://codereview.chromium.org/2652953003
Cr-Commit-Position: refs/heads/master@{#445760}
Committed:
https://chromium.googlesource.com/chromium/src/+/92bce5eb5a81dd0ed238621622c9...
==========

[commit-bot: I haz the power, 2017-01-24 18:14:00]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/92bce5eb5a81dd0ed238621622c9...