Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4749)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

Issue 2652953003: 📰 Simplify application of partial updates on view holders (Closed)
Patch Set: fail on unknown payload Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
index a74ae55115000b5e1851ae42780091f85547780b..156bb65ee6dcc678dc30af589299af3b27a91409 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
@@ -19,6 +19,7 @@
import org.chromium.chrome.browser.offlinepages.ClientId;
import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
import org.chromium.chrome.browser.offlinepages.OfflinePageItem;
+import org.chromium.chrome.browser.suggestions.PartialUpdateId;
import org.chromium.chrome.browser.suggestions.SuggestionsRanker;
import org.chromium.chrome.browser.suggestions.SuggestionsUiDelegate;
@@ -104,14 +105,12 @@ public int getItemViewType(int position) {
}
@Override
- public void onBindViewHolder(
- NewTabPageViewHolder holder, int position, List<Object> payloads) {
+ public void onBindViewHolder(NewTabPageViewHolder holder, int position) {
checkIndex(position);
assert holder instanceof SnippetArticleViewHolder;
SnippetArticle suggestion = getSuggestionAt(position);
mSuggestionsRanker.rankSuggestion(suggestion);
- ((SnippetArticleViewHolder) holder)
- .onBindViewHolder(suggestion, mCategoryInfo, payloads);
+ ((SnippetArticleViewHolder) holder).onBindViewHolder(suggestion, mCategoryInfo);
}
@Override
@@ -190,7 +189,7 @@ public void updateSuggestionOfflineId(SnippetArticle article, Long newId) {
article.setOfflinePageOfflineId(newId);
if ((oldId == null) == (newId == null)) return;
- notifyItemChanged(index, SnippetArticleViewHolder.PARTIAL_UPDATE_OFFLINE_ID);
+ notifyItemChanged(index, PartialUpdateId.OFFLINE_BADGE);
}
}
@@ -256,8 +255,8 @@ public void onItemRangeRemoved(TreeNode child, int index, int count) {
}
@Override
- public void onBindViewHolder(NewTabPageViewHolder holder, int position, List<Object> payloads) {
- super.onBindViewHolder(holder, position, payloads);
+ public void onBindViewHolder(NewTabPageViewHolder holder, int position) {
+ super.onBindViewHolder(holder, position);
childSeen(position);
}

Powered by Google App Engine
This is Rietveld 408576698