Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2972)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

Issue 2652953003: 📰 Simplify application of partial updates on view holders (Closed)
Patch Set: fail on unknown payload Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
index a96cbd38736466cea6e33738c9558591e87f9ef2..231225b372136ab629b358d460d0de93e91122ed 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
@@ -43,7 +43,6 @@
import java.net.URI;
import java.net.URISyntaxException;
-import java.util.List;
import java.util.concurrent.TimeUnit;
/**
@@ -57,8 +56,6 @@
private static final String FAVICON_SERVICE_FORMAT =
"https://s2.googleusercontent.com/s2/favicons?domain=%s&src=chrome_newtab_mobile&sz=%d&alt=404";
- public static final int PARTIAL_UPDATE_OFFLINE_ID = 1;
-
private final SuggestionsUiDelegate mUiDelegate;
private final TextView mHeadlineTextView;
private final TextView mPublisherTextView;
@@ -227,13 +224,7 @@ private static String getAttributionString(SnippetArticle article) {
BidiFormatter.getInstance().unicodeWrap(article.mPublisher), relativeTimeSpan);
}
- public void onBindViewHolder(
- SnippetArticle article, SuggestionsCategoryInfo categoryInfo, List<Object> payloads) {
- if (!payloads.isEmpty() && article.equals(mArticle)) {
- performPartialBind(payloads);
- return;
- }
-
+ public void onBindViewHolder(SnippetArticle article, SuggestionsCategoryInfo categoryInfo) {
super.onBindViewHolder();
mArticle = article;
@@ -279,19 +270,14 @@ public void onBindViewHolder(
mRecyclerView.onSnippetBound(itemView);
}
- private void refreshOfflineBadgeVisibility() {
+ /** Updates the visibility of the card's offline badge by checking the bound article's info. */
+ public void refreshOfflineBadgeVisibility() {
if (!SnippetsConfig.isOfflineBadgeEnabled()) return;
boolean visible = mArticle.getOfflinePageOfflineId() != null || mArticle.mIsAssetDownload;
if (visible == (mOfflineBadge.getVisibility() == View.VISIBLE)) return;
mOfflineBadge.setVisibility(visible ? View.VISIBLE : View.GONE);
}
- private void performPartialBind(List<Object> payload) {
- if (payload.contains(PARTIAL_UPDATE_OFFLINE_ID)) {
- refreshOfflineBadgeVisibility();
- }
- }
-
private static class FetchImageCallback extends Callback<Bitmap> {
private SnippetArticleViewHolder mViewHolder;
private final SnippetArticle mSnippet;

Powered by Google App Engine
This is Rietveld 408576698