Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java

Issue 2652953003: 📰 Simplify application of partial updates on view holders (Closed)
Patch Set: fail on unknown payload Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/ContentSuggestionsTestUtils.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java
index 8217f763b42f1b3db209a730365ea9b2f6ce6828..4d1596ecd950b6cf50007383f7ca969d67a50382 100644
--- a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java
@@ -30,8 +30,6 @@
import org.chromium.testing.local.LocalRobolectricTestRunner;
import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Collections;
import java.util.List;
/**
@@ -81,17 +79,15 @@ public void testGetItemViewType() {
@Test
public void testBindViewHolder() {
NewTabPageViewHolder holder = mock(NewTabPageViewHolder.class);
- List<Object> payload1 = Collections.emptyList();
- List<Object> payload2 = Arrays.<Object>asList("some data", "some other data");
- mInnerNode.onBindViewHolder(holder, 0, payload1);
- mInnerNode.onBindViewHolder(holder, 5, payload1);
- mInnerNode.onBindViewHolder(holder, 6, payload2);
- mInnerNode.onBindViewHolder(holder, 11, payload1);
-
- verify(mChildren.get(0)).onBindViewHolder(holder, 0, payload1);
- verify(mChildren.get(2)).onBindViewHolder(holder, 2, payload1);
- verify(mChildren.get(4)).onBindViewHolder(holder, 0, payload2);
- verify(mChildren.get(6)).onBindViewHolder(holder, 0, payload1);
+ mInnerNode.onBindViewHolder(holder, 0);
+ mInnerNode.onBindViewHolder(holder, 5);
+ mInnerNode.onBindViewHolder(holder, 6);
+ mInnerNode.onBindViewHolder(holder, 11);
+
+ verify(mChildren.get(0)).onBindViewHolder(holder, 0);
+ verify(mChildren.get(2)).onBindViewHolder(holder, 2);
+ verify(mChildren.get(4)).onBindViewHolder(holder, 0);
+ verify(mChildren.get(6)).onBindViewHolder(holder, 0);
}
@Test
« no previous file with comments | « chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/ContentSuggestionsTestUtils.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698