Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2651693002: [Reading List iOS] Display distilled URL instead of entry URL in omnibox (Closed)

Created:
3 years, 11 months ago by Olivier
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Reading List iOS] Display distilled URL instead of entry URL in omnibox When displaying an offline page, the URL must be the actual distilled URL and not the Reading List entry URL (which can be a short URL like goo.gl/...). BUG=682666 Review-Url: https://codereview.chromium.org/2644293002 Cr-Commit-Position: refs/heads/master@{#445077} (cherry picked from commit 457f401daa5e0667546ab2a96afea821c6e5d88f) Review-Url: https://codereview.chromium.org/2651693002 . Cr-Commit-Position: refs/branch-heads/2987@{#24} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/a86f2882f704d63752ad43dd56950f41e54b9a46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -48 lines) Patch
M ios/chrome/browser/reading_list/offline_url_utils.h View 1 chunk +15 lines, -5 lines 0 comments Download
M ios/chrome/browser/reading_list/offline_url_utils.cc View 3 chunks +23 lines, -5 lines 0 comments Download
M ios/chrome/browser/reading_list/offline_url_utils_unittest.cc View 1 chunk +56 lines, -15 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_web_state_observer.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_web_state_observer_unittest.mm View 3 chunks +4 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/offline_page_native_content.mm View 5 chunks +14 lines, -9 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/offline_page_native_content_unittest.mm View 4 chunks +40 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Olivier
3 years, 11 months ago (2017-01-23 15:28:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a86f2882f704d63752ad43dd56950f41e54b9a46.

Powered by Google App Engine
This is Rietveld 408576698