ios/chrome/browser/reading_list/reading_list_web_state_observer_unittest.mm - Issue 2651693002: [Reading List iOS] Display distilled URL instead of entry URL in omnibox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/reading_list/reading_list_web_state_observer_unittest.mm

Issue 2651693002: [Reading List iOS] Display distilled URL instead of entry URL in omnibox (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/reading_list/reading_list_web_state_observer.mm ('k') | ios/chrome/browser/ui/reading_list/offline_page_native_content.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/reading_list/reading_list_web_state_observer_unittest.mm

diff --git a/ios/chrome/browser/reading_list/reading_list_web_state_observer_unittest.mm b/ios/chrome/browser/reading_list/reading_list_web_state_observer_unittest.mm

index 692625dadf375e8d287b25dbf6b33473c5a82600..302da75583a5eee899474495d1b2497e93f8fe86 100644

--- a/ios/chrome/browser/reading_list/reading_list_web_state_observer_unittest.mm

+++ b/ios/chrome/browser/reading_list/reading_list_web_state_observer_unittest.mm

@@ -96,8 +96,6 @@ TEST_F(ReadingListWebStateObserverTest, TestLoadReadingListOnline) {

reading_list_model_->SetEntryDistilledInfo(

url, base::FilePath(distilled_path), GURL(kTestDistilledURL));

const ReadingListEntry* entry = reading_list_model_->GetEntryByURL(url);

- GURL distilled_url =

- reading_list::DistilledURLForPath(entry->DistilledPath(), entry->URL());

test_navigation_manager_->GetPendingItem()->SetURL(url);

test_web_state_.SetLoading(true);

@@ -120,8 +118,8 @@ TEST_F(ReadingListWebStateObserverTest, TestLoadReadingListDistilledCommitted) {

reading_list_model_->SetEntryDistilledInfo(

url, base::FilePath(distilled_path), GURL(kTestDistilledURL));

const ReadingListEntry* entry = reading_list_model_->GetEntryByURL(url);

- GURL distilled_url =

- reading_list::DistilledURLForPath(entry->DistilledPath(), entry->URL());

+ GURL distilled_url = reading_list::OfflineURLForPath(

+ entry->DistilledPath(), entry->URL(), entry->DistilledURL());

// Test on commited entry, there must be no pending item.

test_navigation_manager_->SetPendingItem(nullptr);

@@ -146,8 +144,8 @@ TEST_F(ReadingListWebStateObserverTest, TestLoadReadingListDistilledPending) {

reading_list_model_->SetEntryDistilledInfo(

url, base::FilePath(distilled_path), GURL(kTestDistilledURL));

const ReadingListEntry* entry = reading_list_model_->GetEntryByURL(url);

- GURL distilled_url =

- reading_list::DistilledURLForPath(entry->DistilledPath(), entry->URL());

+ GURL distilled_url = reading_list::OfflineURLForPath(

+ entry->DistilledPath(), entry->URL(), entry->DistilledURL());

test_navigation_manager_->SetPendingItem(nil);

test_navigation_manager_->GetLastCommittedItem()->SetURL(url);