ios/chrome/browser/reading_list/reading_list_web_state_observer.mm - Issue 2651693002: [Reading List iOS] Display distilled URL instead of entry URL in omnibox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/reading_list/reading_list_web_state_observer.mm

Issue 2651693002: [Reading List iOS] Display distilled URL instead of entry URL in omnibox (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/reading_list/reading_list_web_state_observer.mm

diff --git a/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm b/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm

index f1518742d7a8839a888aa775b21daa406f3152d6..0cbc02da6de05db868dc4b3f9d7576b10e0c7fde 100644

--- a/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm

+++ b/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm

@@ -280,8 +280,8 @@ void ReadingListWebStateObserver::LoadOfflineReadingListEntry() {

reading_list_model_->GetEntryByURL(pending_url_);

last_load_was_offline_ = true;

DCHECK(entry->DistilledState() == ReadingListEntry::PROCESSED);

- GURL url =

- reading_list::DistilledURLForPath(entry->DistilledPath(), entry->URL());

+ GURL url = reading_list::OfflineURLForPath(

+ entry->DistilledPath(), entry->URL(), entry->DistilledURL());

web::NavigationManager* navigationManager =

web_state()->GetNavigationManager();

web::NavigationItem* item = navigationManager->GetPendingItem();