Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: ios/chrome/browser/reading_list/offline_url_utils.h

Issue 2651693002: [Reading List iOS] Display distilled URL instead of entry URL in omnibox (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/reading_list/offline_url_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/reading_list/offline_url_utils.h
diff --git a/ios/chrome/browser/reading_list/offline_url_utils.h b/ios/chrome/browser/reading_list/offline_url_utils.h
index c2c0dcc20924ca870fb1d8fe87071a1306828f68..d7af133b49e0e8f24e29d7bcecd2c71dbe3d10f7 100644
--- a/ios/chrome/browser/reading_list/offline_url_utils.h
+++ b/ios/chrome/browser/reading_list/offline_url_utils.h
@@ -14,11 +14,21 @@
namespace reading_list {
// The distilled URL chrome://offline/... that will load the file at |path|.
-GURL DistilledURLForPath(const base::FilePath& path, const GURL& virtual_url);
-
-// If |distilled_url| has a query "virtualURL" query params that is a URL,
-// returns it. If not, return |distilled_url|
-GURL VirtualURLForDistilledURL(const GURL& distilled_url);
+// |entry_url| is the URL of the ReadingListEntry.
+// |virtual_url| is the URL to display in the omnibox. This can be different
+// from |entry_url| is the distillation was done after a redirection.
+// |entry_url| and |virtual_url| are optionnal.
+GURL OfflineURLForPath(const base::FilePath& distilled_path,
+ const GURL& entry_url,
+ const GURL& virtual_url);
+
+// If |offline_url| has a "entryURL" query params that is a URL, returns it.
+// If not, return |offline_url|
+GURL EntryURLForOfflineURL(const GURL& offline_url);
+
+// If |offline_url| has a "virtualURL" query params that is a URL, returns it.
+// If not, return |EntryURLForOfflineURL(|offline_url|)|
+GURL VirtualURLForOfflineURL(const GURL& offline_url);
// The file URL pointing to the local file to load to display |distilled_url|.
// If |resources_root_url| is not nullptr, it is set to a file URL to the
« no previous file with comments | « no previous file | ios/chrome/browser/reading_list/offline_url_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698