Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2651533004: Add TransitionKeyframeEffectModel specialisation (Closed)

Created:
3 years, 11 months ago by alancutter (OOO until 2018)
Modified:
3 years, 10 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TransitionKeyframeEffectModel specialisation This patch is part of refactoring CSS Transitions to use CSSInterpolationTypes instead of AnimatableValues: https://codereview.chromium.org/2680923005 BUG=681424 Review-Url: https://codereview.chromium.org/2651533004 Cr-Commit-Position: refs/heads/master@{#451563} Committed: https://chromium.googlesource.com/chromium/src/+/8c72872d7955bffc87b46ce9eff180ed5b0beb4d

Patch Set 1 #

Patch Set 2 : lint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M third_party/WebKit/Source/core/animation/KeyframeEffectModel.h View 1 8 chunks +25 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (11 generated)
alancutter (OOO until 2018)
3 years, 10 months ago (2017-02-16 04:33:42 UTC) #3
suzyh_UTC10 (ex-contributor)
The amount of boilerplate here is nasty, but I won't block this refactor on figuring ...
3 years, 10 months ago (2017-02-17 00:26:48 UTC) #4
alancutter (OOO until 2018)
On 2017/02/17 at 00:26:48, suzyh wrote: > The amount of boilerplate here is nasty, but ...
3 years, 10 months ago (2017-02-17 00:37:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651533004/20001
3 years, 10 months ago (2017-02-20 02:43:05 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/391568)
3 years, 10 months ago (2017-02-20 04:28:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651533004/20001
3 years, 10 months ago (2017-02-20 04:38:07 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 05:40:48 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8c72872d7955bffc87b46ce9eff1...

Powered by Google App Engine
This is Rietveld 408576698