Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2693823002: Allow CSSTransformInterpolationType to merge interpolated values together (Closed)

Created:
3 years, 10 months ago by alancutter (OOO until 2018)
Modified:
3 years, 10 months ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow CSSTransformInterpolationType to merge interpolated values together This patch is part of refactoring CSS Transitions to use CSSInterpolationTypes instead of AnimatableValues: https://codereview.chromium.org/2680923005 When using CSSInterpolationTypes for CSS Transitions we need to be able to use interpolated InterpolationValues as keyframe values for retargeted composited transitions. This patch ensures CSSTransformInterpolationType has the ability to do this. BUG=681424 Review-Url: https://codereview.chromium.org/2693823002 Cr-Commit-Position: refs/heads/master@{#451565} Committed: https://chromium.googlesource.com/chromium/src/+/8f73251b30347e8e66d536dde147da1d83b07cbb

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp View 4 chunks +16 lines, -13 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
alancutter (OOO until 2018)
3 years, 10 months ago (2017-02-16 04:36:10 UTC) #3
alancutter (OOO until 2018)
ericwilligers: Ping.
3 years, 10 months ago (2017-02-20 00:10:30 UTC) #4
Eric Willigers
lgtm
3 years, 10 months ago (2017-02-20 02:32:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693823002/20001
3 years, 10 months ago (2017-02-20 05:41:48 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 05:50:24 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8f73251b30347e8e66d536dde147...

Powered by Google App Engine
This is Rietveld 408576698