Add TransitionKeyframe class for CSS Transition refactor

Add TransitionKeyframe class for CSS Transition refactor

This patch is part of refactoring CSS Transitions to use
CSSInterpolationTypes instead of AnimatableValues:
https://codereview.chromium.org/2680923005

The TransitionKeyframe class represents animation keyframes
of a CSS transition. It is created to replace the use of
AnimatableValueKeyframes while using InterpolationValues
instead of AnimatableValues.

BUG=681424
Review-Url: https://codereview.chromium.org/2651553004
Cr-Commit-Position: refs/heads/master@{#451542}
Committed: https://chromium.googlesource.com/chromium/src/+/32281b4e0848e645fc4bf6e568179088ca870a22

[Eric Willigers, 2017-02-09 04:58:30]

ericwilligers@chromium.org changed reviewers:
+ ericwilligers@chromium.org

[Eric Willigers, 2017-02-09 04:58:31]

https://codereview.chromium.org/2651553004/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.cpp
(right):

https://codereview.chromium.org/2651553004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.cpp:8:
#include "core/animation/TransitionKeyframe.h"
Needed ?

[alancutter (OOO until 2018), 2017-02-16 04:01:17]

Description was changed from

==========
Add TransitionKeyframe class

BUG=681424
==========

to

==========
Add TransitionKeyframe class for CSS Transition refactor

This patch is part of refactoring CSS Transitions to use
CSSInterpolationTypes instead of AnimatableValues:
https://codereview.chromium.org/2680923005

The TransitionKeyframe class represents animation keyframes
of a CSS transition. It is created to replace the use of
AnimatableValueKeyframes instead using InterpolationValues
over AnimatableValues.

BUG=681424
==========

[alancutter (OOO until 2018), 2017-02-16 04:01:33]

Description was changed from

==========
Add TransitionKeyframe class for CSS Transition refactor

This patch is part of refactoring CSS Transitions to use
CSSInterpolationTypes instead of AnimatableValues:
https://codereview.chromium.org/2680923005

The TransitionKeyframe class represents animation keyframes
of a CSS transition. It is created to replace the use of
AnimatableValueKeyframes instead using InterpolationValues
over AnimatableValues.

BUG=681424
==========

to

==========
Add TransitionKeyframe class for CSS Transition refactor

This patch is part of refactoring CSS Transitions to use
CSSInterpolationTypes instead of AnimatableValues:
https://codereview.chromium.org/2680923005

The TransitionKeyframe class represents animation keyframes
of a CSS transition. It is created to replace the use of
AnimatableValueKeyframes while using InterpolationValues
instead of AnimatableValues.

BUG=681424
==========

[alancutter (OOO until 2018), 2017-02-16 04:01:43]

https://codereview.chromium.org/2651553004/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.cpp
(right):

https://codereview.chromium.org/2651553004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.cpp:8:
#include "core/animation/TransitionKeyframe.h"
On 2017/02/09 at 04:58:30, Eric Willigers wrote:
> Needed ?

Removed.

[Eric Willigers, 2017-02-17 00:27:45]

lgtm

[alancutter (OOO until 2018), 2017-02-17 00:39:52]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 00:41:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 02:44:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 02:44:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[alancutter (OOO until 2018), 2017-02-20 00:08:04]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2017-02-20 00:08:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 01:59:32]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487549284378990,
"parent_rev": "d0dfa19bdd289d481228e9da89b6ffb0040a9aaa", "commit_rev":
"32281b4e0848e645fc4bf6e568179088ca870a22"}

[commit-bot: I haz the power, 2017-02-20 02:00:22]

Description was changed from

==========
Add TransitionKeyframe class for CSS Transition refactor

This patch is part of refactoring CSS Transitions to use
CSSInterpolationTypes instead of AnimatableValues:
https://codereview.chromium.org/2680923005

The TransitionKeyframe class represents animation keyframes
of a CSS transition. It is created to replace the use of
AnimatableValueKeyframes while using InterpolationValues
instead of AnimatableValues.

BUG=681424
==========

to

==========
Add TransitionKeyframe class for CSS Transition refactor

This patch is part of refactoring CSS Transitions to use
CSSInterpolationTypes instead of AnimatableValues:
https://codereview.chromium.org/2680923005

The TransitionKeyframe class represents animation keyframes
of a CSS transition. It is created to replace the use of
AnimatableValueKeyframes while using InterpolationValues
instead of AnimatableValues.

BUG=681424

Review-Url: https://codereview.chromium.org/2651553004
Cr-Commit-Position: refs/heads/master@{#451542}
Committed:
https://chromium.googlesource.com/chromium/src/+/32281b4e0848e645fc4bf6e56817...
==========

[commit-bot: I haz the power, 2017-02-20 02:00:23]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/32281b4e0848e645fc4bf6e56817...