Revert of Decouple GpuCompositorFrameSink from DisplayCompositor

Revert of Decouple GpuCompositorFrameSink from DisplayCompositor (patchset #7 id:120001 of https://codereview.chromium.org/2654693003/ )

Reason for revert:
Broke Win 64 builder's compile step:
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/7950

[23910/48389] CXX obj/content/app/content_main_runner_child/content_main_runner.obj
FAILED: obj/content/app/content_main_runner_child/content_main_runner.obj 
ninja -t msvc -e environment.x64 -- C:\b\c\cipd\goma/gomacc.exe "C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/content/app/content_main_runner_child/content_main_runner.obj.rsp /c ../../content/app/content_main_runner.cc /Foobj/content/app/content_main_runner_child/content_main_runner.obj /Fd"obj/content/app/content_main_runner_child_cc.pdb"
c:\b\c\b\win_x64_archive\src\content\browser\gpu\gpu_process_host.h(32): fatal error C1083: Cannot open include file: 'services/ui/gpu/interfaces/gpu_host.mojom.h': No such file or directory

Original issue's description:
> Decouple GpuCompositorFrameSink from DisplayCompositor
> 
> In order to reuse GpuCompositorFrameSink in other parts of Chrome 
> (e.g. OffscreenCanvas), this CL decouples 
> GpuCompositorFrameSinkSupport from DisplayCompositor.
> 
> This CL also moves GpuCompositorFrameSInk out of 
> services/ui/surfaces for now as well because we would like to use 
> this code in Chrome and this is currently an incomplete internal
> implementation detail of Mus. Once code is unified between Chrome
> and Mus, components/display_compositor can probably move to 
> services/ui/gpu/display_compositor.
> 
> BUG=683735
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> 
> Review-Url: https://codereview.chromium.org/2654693003
> Cr-Commit-Position: refs/heads/master@{#446223}
> Committed: https://chromium.googlesource.com/chromium/src/+/81183e45cf14c416dfce69b990a0c71a4e1c3399

TBR=fsamuel@chromium.org,ben@chromium.org,kylechar@chromium.org,jam@chromium.org,danakj@chromium.org,xing.xu@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=683735
Review-Url: https://codereview.chromium.org/2651213004
Cr-Commit-Position: refs/heads/master@{#446233}
Committed: https://chromium.googlesource.com/chromium/src/+/c850f7de840cdb2c21ee10166a76c2acbf04cc01

[Dan Beam, 2017-01-26 05:28:19]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-01-26 05:28:19]

Created Revert of Decouple GpuCompositorFrameSink from DisplayCompositor

[commit-bot: I haz the power, 2017-01-26 05:28:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 05:29:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485408499039050, "parent_rev":
"fc1f65c1189b644cd27c8a5fa47861dd4f68859d", "commit_rev":
"c850f7de840cdb2c21ee10166a76c2acbf04cc01"}

[Dan Beam, 2017-01-26 05:30:31]

The CQ bit was unchecked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-01-26 05:30:46]

Description was changed from

==========
Revert of Decouple GpuCompositorFrameSink from DisplayCompositor (patchset #7
id:120001 of https://codereview.chromium.org/2654693003/ )

Reason for revert:
Broke Win 64 builder's compile step:
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/7950

[23910/48389] CXX
obj/content/app/content_main_runner_child/content_main_runner.obj
FAILED: obj/content/app/content_main_runner_child/content_main_runner.obj 
ninja -t msvc -e environment.x64 -- C:\b\c\cipd\goma/gomacc.exe
"C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64/cl.exe"
/nologo /showIncludes /FC
@obj/content/app/content_main_runner_child/content_main_runner.obj.rsp /c
../../content/app/content_main_runner.cc
/Foobj/content/app/content_main_runner_child/content_main_runner.obj
/Fd"obj/content/app/content_main_runner_child_cc.pdb"
c:\b\c\b\win_x64_archive\src\content\browser\gpu\gpu_process_host.h(32): fatal
error C1083: Cannot open include file:
'services/ui/gpu/interfaces/gpu_host.mojom.h': No such file or directory

Original issue's description:
> Decouple GpuCompositorFrameSink from DisplayCompositor
> 
> In order to reuse GpuCompositorFrameSink in other parts of Chrome 
> (e.g. OffscreenCanvas), this CL decouples 
> GpuCompositorFrameSinkSupport from DisplayCompositor.
> 
> This CL also moves GpuCompositorFrameSInk out of 
> services/ui/surfaces for now as well because we would like to use 
> this code in Chrome and this is currently an incomplete internal
> implementation detail of Mus. Once code is unified between Chrome
> and Mus, components/display_compositor can probably move to 
> services/ui/gpu/display_compositor.
> 
> BUG=683735
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> 
> Review-Url: https://codereview.chromium.org/2654693003
> Cr-Commit-Position: refs/heads/master@{#446223}
> Committed:
https://chromium.googlesource.com/chromium/src/+/81183e45cf14c416dfce69b990a0...

TBR=fsamuel@chromium.org,ben@chromium.org,kylechar@chromium.org,jam@chromium....
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=683735
==========

to

==========
Revert of Decouple GpuCompositorFrameSink from DisplayCompositor (patchset #7
id:120001 of https://codereview.chromium.org/2654693003/ )

Reason for revert:
Broke Win 64 builder's compile step:
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/7950

[23910/48389] CXX
obj/content/app/content_main_runner_child/content_main_runner.obj
FAILED: obj/content/app/content_main_runner_child/content_main_runner.obj 
ninja -t msvc -e environment.x64 -- C:\b\c\cipd\goma/gomacc.exe
"C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64/cl.exe"
/nologo /showIncludes /FC
@obj/content/app/content_main_runner_child/content_main_runner.obj.rsp /c
../../content/app/content_main_runner.cc
/Foobj/content/app/content_main_runner_child/content_main_runner.obj
/Fd"obj/content/app/content_main_runner_child_cc.pdb"
c:\b\c\b\win_x64_archive\src\content\browser\gpu\gpu_process_host.h(32): fatal
error C1083: Cannot open include file:
'services/ui/gpu/interfaces/gpu_host.mojom.h': No such file or directory

Original issue's description:
> Decouple GpuCompositorFrameSink from DisplayCompositor
> 
> In order to reuse GpuCompositorFrameSink in other parts of Chrome 
> (e.g. OffscreenCanvas), this CL decouples 
> GpuCompositorFrameSinkSupport from DisplayCompositor.
> 
> This CL also moves GpuCompositorFrameSInk out of 
> services/ui/surfaces for now as well because we would like to use 
> this code in Chrome and this is currently an incomplete internal
> implementation detail of Mus. Once code is unified between Chrome
> and Mus, components/display_compositor can probably move to 
> services/ui/gpu/display_compositor.
> 
> BUG=683735
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> 
> Review-Url: https://codereview.chromium.org/2654693003
> Cr-Commit-Position: refs/heads/master@{#446223}
> Committed:
https://chromium.googlesource.com/chromium/src/+/81183e45cf14c416dfce69b990a0...

TBR=fsamuel@chromium.org,ben@chromium.org,kylechar@chromium.org,jam@chromium....
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=683735

Review-Url: https://codereview.chromium.org/2651213004
Cr-Commit-Position: refs/heads/master@{#446233}
Committed:
https://chromium.googlesource.com/chromium/src/+/c850f7de840cdb2c21ee10166a76...
==========

[commit-bot: I haz the power, 2017-01-26 05:30:47]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c850f7de840cdb2c21ee10166a76...

[Dan Beam, 2017-01-26 05:31:19]

sorry, just found https://bugs.chromium.org/p/chromium/issues/detail?id=685440
and evidence that this happened earlier today as well (before your patch)

hopefully stopped the CQ in time.  if not: sorry!

[xing.xu, 2017-01-26 05:41:51]

On 2017/01/26 05:31:19, Dan Beam wrote:
> sorry, just found https://bugs.chromium.org/p/chromium/issues/detail?id=685440
> and evidence that this happened earlier today as well (before your patch)
> 
> hopefully stopped the CQ in time.  if not: sorry!

So, should I re-land this patch again?

[kjellander_chromium, 2017-01-26 05:47:58]

On 2017/01/26 05:41:51, xing.xu wrote:
> On 2017/01/26 05:31:19, Dan Beam wrote:
> > sorry, just found
https://bugs.chromium.org/p/chromium/issues/detail?id=685440
> > and evidence that this happened earlier today as well (before your patch)
> > 
> > hopefully stopped the CQ in time.  if not: sorry!
> 
> So, should I re-land this patch again?

Please do (or let me know if I shall do it for you).

[xing.xu, 2017-01-26 06:28:03]

I tried git cl reland, but it failed and my local code seems in mess. Is there
any document about how to git cl reland?

Then I tried git cherry-pick, and re-land it here:
https://codereview.chromium.org/2651283004/

On 2017/01/26 05:47:58, kjellander_chromium wrote:
> On 2017/01/26 05:41:51, xing.xu wrote:
> > On 2017/01/26 05:31:19, Dan Beam wrote:
> > > sorry, just found
> https://bugs.chromium.org/p/chromium/issues/detail?id=685440
> > > and evidence that this happened earlier today as well (before your patch)
> > > 
> > > hopefully stopped the CQ in time.  if not: sorry!
> > 
> > So, should I re-land this patch again?
> 
> Please do (or let me know if I shall do it for you).