Decouple GpuCompositorFrameSink from DisplayCompositor

Decouple GpuCompositorFrameSink from DisplayCompositor

In order to reuse GpuCompositorFrameSink in other parts of Chrome 
(e.g. OffscreenCanvas), this CL decouples 
GpuCompositorFrameSinkSupport from DisplayCompositor.

This CL also moves GpuCompositorFrameSInk out of 
services/ui/surfaces for now as well because we would like to use 
this code in Chrome and this is currently an incomplete internal
implementation detail of Mus. Once code is unified between Chrome
and Mus, components/display_compositor can probably move to 
services/ui/gpu/display_compositor.

BUG=683735
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2654693003
Cr-Original-Commit-Position: refs/heads/master@{#446223}
Committed: https://chromium.googlesource.com/chromium/src/+/81183e45cf14c416dfce69b990a0c71a4e1c3399
Review-Url: https://codereview.chromium.org/2654693003
Cr-Commit-Position: refs/heads/master@{#446540}
Committed: https://chromium.googlesource.com/chromium/src/+/c6c67d47aec05f4dc57da4ac6bd92f617ecac9e1

[xing.xu, 2017-01-24 08:22:38]

Description was changed from

==========
Decouple GpuCompositorFrameSink from DisplayCompositor

BUG=683735
==========

to

==========
Decouple GpuCompositorFrameSink from DisplayCompositor

BUG=683735
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[xing.xu, 2017-01-24 08:23:09]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 08:23:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xing.xu, 2017-01-24 08:30:03]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 08:30:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xing.xu, 2017-01-24 08:48:11]

Description was changed from

==========
Decouple GpuCompositorFrameSink from DisplayCompositor

BUG=683735
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Decouple GpuCompositorFrameSink from DisplayCompositor

BUG=683735
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[xing.xu, 2017-01-24 08:48:11]

xing.xu@intel.com changed reviewers:
+ fsamuel@chromium.org

[xing.xu, 2017-01-24 08:50:12]

PTAL. 

BTW, does it better put 
services/ui/surfaces/gpu_compositor_frame_sink_delegate.h
into cc/surfaces/compositor_frame_sink_delegate.h?

[commit-bot: I haz the power, 2017-01-24 09:27:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 09:27:31]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2017-01-24 13:09:43]

This is helpful! Thank you!

https://codereview.chromium.org/2654693003/diff/20001/cc/surfaces/compositor_...
File cc/surfaces/compositor_frame_sink_delegate.h (right):

https://codereview.chromium.org/2654693003/diff/20001/cc/surfaces/compositor_...
cc/surfaces/compositor_frame_sink_delegate.h:12: class
CompositorFrameSinkDelegate {
Call it GpuCompositorFrameSinkDelegate. Also, it was discussed in another bug.
We'd like to place all service-side code in components/display_compositor.

Please place GpuCompositorFrameSinkDelegate, and GpuCompositorFrameSink,
GpuOffscreenCompositorFrameSink and GpuDisplayCompositorFrameSink in
components/display_compositor.

https://codereview.chromium.org/2654693003/diff/20001/services/ui/surfaces/gp...
File services/ui/surfaces/gpu_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2654693003/diff/20001/services/ui/surfaces/gp...
services/ui/surfaces/gpu_compositor_frame_sink.cc:98: void
GpuCompositorFrameSink::AddSurfaceReferences(
Move this to SurfaceManager.

https://codereview.chromium.org/2654693003/diff/20001/services/ui/surfaces/gp...
services/ui/surfaces/gpu_compositor_frame_sink.cc:106: void
GpuCompositorFrameSink::RemoveSurfaceReferences(
I'd just move this to SurfaceManager.

[xing.xu, 2017-01-25 06:37:31]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 06:37:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xing.xu, 2017-01-25 06:39:37]

xing.xu@intel.com changed reviewers:
+ ben@chromium.org, kylechar@chromium.org

[commit-bot: I haz the power, 2017-01-25 06:41:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 06:41:53]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[xing.xu, 2017-01-25 10:10:51]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 10:11:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 11:30:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 11:30:28]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[xing.xu, 2017-01-25 13:41:13]

Done. PTAL.
BTW, there is a c4275-warning in windows dbg build. Should I ignore it?

Reference for c4275-warning:
http://stackoverflow.com/questions/5207765/c4275-warning-in-visual-studio
https://msdn.microsoft.com/en-us/library/3tdb471s.aspx 

On 2017/01/24 13:09:43, Fady Samuel wrote:
> This is helpful! Thank you!
> 
>
https://codereview.chromium.org/2654693003/diff/20001/cc/surfaces/compositor_...
> File cc/surfaces/compositor_frame_sink_delegate.h (right):
> 
>
https://codereview.chromium.org/2654693003/diff/20001/cc/surfaces/compositor_...
> cc/surfaces/compositor_frame_sink_delegate.h:12: class
> CompositorFrameSinkDelegate {
> Call it GpuCompositorFrameSinkDelegate. Also, it was discussed in another bug.
> We'd like to place all service-side code in components/display_compositor.
> 
> Please place GpuCompositorFrameSinkDelegate, and GpuCompositorFrameSink,
> GpuOffscreenCompositorFrameSink and GpuDisplayCompositorFrameSink in
> components/display_compositor.
> 
>
https://codereview.chromium.org/2654693003/diff/20001/services/ui/surfaces/gp...
> File services/ui/surfaces/gpu_compositor_frame_sink.cc (right):
> 
>
https://codereview.chromium.org/2654693003/diff/20001/services/ui/surfaces/gp...
> services/ui/surfaces/gpu_compositor_frame_sink.cc:98: void
> GpuCompositorFrameSink::AddSurfaceReferences(
> Move this to SurfaceManager.
> 
>
https://codereview.chromium.org/2654693003/diff/20001/services/ui/surfaces/gp...
> services/ui/surfaces/gpu_compositor_frame_sink.cc:106: void
> GpuCompositorFrameSink::RemoveSurfaceReferences(
> I'd just move this to SurfaceManager.

[Fady Samuel, 2017-01-25 13:51:23]

lgtm + comment. Also could you please add more to the description:

In order to reuse GpuCompositorFrameSink in other parts of Chrome (e.g.
OffscreenCanvas), this CL decouples 
GpuCompositorFrameSinkSupport from DisplayCompositor.

This CL also moves GpuCompositorFrameSInk out of services/ui/surfaces for now as
well because we would like to use this code in Chrome and this is currently an
incomplete internal implementation detail of Mus. Once code is unified between
Chrome and Mus, components/display_compositor can probably move to
services/ui/gpu/display_compositor.

https://codereview.chromium.org/2654693003/diff/60001/components/display_comp...
File components/display_compositor/gpu_compositor_frame_sink.h (left):

https://codereview.chromium.org/2654693003/diff/60001/components/display_comp...
components/display_compositor/gpu_compositor_frame_sink.h:30: : public
cc::CompositorFrameSinkSupportClient,
public NON_EXPORTED_BASE(cc::CompositorFrameSinkSupportClient)

[Fady Samuel, 2017-01-25 13:51:51]

On 2017/01/25 13:51:23, Fady Samuel wrote:
> lgtm + comment. Also could you please add more to the description:
> 
> In order to reuse GpuCompositorFrameSink in other parts of Chrome (e.g.
> OffscreenCanvas), this CL decouples 
> GpuCompositorFrameSinkSupport from DisplayCompositor.
> 
> This CL also moves GpuCompositorFrameSInk out of services/ui/surfaces for now
as
> well because we would like to use this code in Chrome and this is currently an
> incomplete internal implementation detail of Mus. Once code is unified between
> Chrome and Mus, components/display_compositor can probably move to
> services/ui/gpu/display_compositor.
> 
>
https://codereview.chromium.org/2654693003/diff/60001/components/display_comp...
> File components/display_compositor/gpu_compositor_frame_sink.h (left):
> 
>
https://codereview.chromium.org/2654693003/diff/60001/components/display_comp...
> components/display_compositor/gpu_compositor_frame_sink.h:30: : public
> cc::CompositorFrameSinkSupportClient,
> public NON_EXPORTED_BASE(cc::CompositorFrameSinkSupportClient)

Thanks for this CL btw! :-)

[Fady Samuel, 2017-01-25 13:54:22]

On 2017/01/25 13:51:23, Fady Samuel wrote:
> lgtm + comment. Also could you please add more to the description:
> 
> In order to reuse GpuCompositorFrameSink in other parts of Chrome (e.g.
> OffscreenCanvas), this CL decouples 
> GpuCompositorFrameSinkSupport from DisplayCompositor.
> 
> This CL also moves GpuCompositorFrameSInk out of services/ui/surfaces for now
as
> well because we would like to use this code in Chrome and this is currently an
> incomplete internal implementation detail of Mus. Once code is unified between
> Chrome and Mus, components/display_compositor can probably move to
> services/ui/gpu/display_compositor.
> 
>
https://codereview.chromium.org/2654693003/diff/60001/components/display_comp...
> File components/display_compositor/gpu_compositor_frame_sink.h (left):
> 
>
https://codereview.chromium.org/2654693003/diff/60001/components/display_comp...
> components/display_compositor/gpu_compositor_frame_sink.h:30: : public
> cc::CompositorFrameSinkSupportClient,
> public NON_EXPORTED_BASE(cc::CompositorFrameSinkSupportClient)

Thanks for this CL btw! :-)

[xing.xu, 2017-01-25 14:15:17]

Description was changed from

==========
Decouple GpuCompositorFrameSink from DisplayCompositor

BUG=683735
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Decouple GpuCompositorFrameSink from DisplayCompositor

In order to reuse GpuCompositorFrameSink in other parts of Chrome 
(e.g. OffscreenCanvas), this CL decouples 
GpuCompositorFrameSinkSupport from DisplayCompositor.

This CL also moves GpuCompositorFrameSInk out of 
services/ui/surfaces for now as well because we would like to use 
this code in Chrome and this is currently an incomplete internal
implementation detail of Mus. Once code is unified between Chrome
and Mus, components/display_compositor can probably move to 
services/ui/gpu/display_compositor.

BUG=683735
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[xing.xu, 2017-01-25 14:29:54]

xing.xu@intel.com changed reviewers:
+ jam@chromium.org

[xing.xu, 2017-01-25 14:30:49]

Description updated, thanks a lot!

On 2017/01/25 13:54:22, Fady Samuel wrote:
> On 2017/01/25 13:51:23, Fady Samuel wrote:
> > lgtm + comment. Also could you please add more to the description:
> > 
> > In order to reuse GpuCompositorFrameSink in other parts of Chrome (e.g.
> > OffscreenCanvas), this CL decouples 
> > GpuCompositorFrameSinkSupport from DisplayCompositor.
> > 
> > This CL also moves GpuCompositorFrameSInk out of services/ui/surfaces for
now
> as
> > well because we would like to use this code in Chrome and this is currently
an
> > incomplete internal implementation detail of Mus. Once code is unified
between
> > Chrome and Mus, components/display_compositor can probably move to
> > services/ui/gpu/display_compositor.
> > 
> >
>
https://codereview.chromium.org/2654693003/diff/60001/components/display_comp...
> > File components/display_compositor/gpu_compositor_frame_sink.h (left):
> > 
> >
>
https://codereview.chromium.org/2654693003/diff/60001/components/display_comp...
> > components/display_compositor/gpu_compositor_frame_sink.h:30: : public
> > cc::CompositorFrameSinkSupportClient,
> > public NON_EXPORTED_BASE(cc::CompositorFrameSinkSupportClient)
> 
> Thanks for this CL btw! :-)

[xing.xu, 2017-01-25 14:30:59]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 14:31:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 15:41:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 15:42:00]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[kylechar, 2017-01-25 15:54:33]

https://codereview.chromium.org/2654693003/diff/80001/cc/surfaces/surface_man...
File cc/surfaces/surface_manager.cc (right):

https://codereview.chromium.org/2654693003/diff/80001/cc/surfaces/surface_man...
cc/surfaces/surface_manager.cc:231: for (const auto& reference : references) {
Get rid of {} since the loop body is only one line.

https://codereview.chromium.org/2654693003/diff/80001/cc/surfaces/surface_man...
cc/surfaces/surface_manager.cc:240: // TODO(kylechar): Each remove reference can
trigger GC, it would be better if
We can easily make this comment a reality now. Run GarbageCollectSurfaces() once
after you go through the list of references to remove and remove the call from
GarbageCollectSurfaces().

https://codereview.chromium.org/2654693003/diff/80001/cc/surfaces/surface_man...
cc/surfaces/surface_manager.cc:242: for (const auto& reference : references) {
Get rid of {} since the loop body is only one line.

https://codereview.chromium.org/2654693003/diff/80001/components/display_comp...
File components/display_compositor/gpu_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2654693003/diff/80001/components/display_comp...
components/display_compositor/gpu_compositor_frame_sink.cc:61:
surface_tracker_.UpdateReferences(local_frame_id,
Can you add the following comment:

// TODO(kylechar): Move adding top-level root references to
GpuDisplayCompositorFrameSink.

https://codereview.chromium.org/2654693003/diff/80001/components/display_comp...
File components/display_compositor/gpu_compositor_frame_sink.h (right):

https://codereview.chromium.org/2654693003/diff/80001/components/display_comp...
components/display_compositor/gpu_compositor_frame_sink.h:30: : public
NON_EXPORTED_BASE(cc::CompositorFrameSinkSupportClient),
I don't think any of these NON_EXPORTED_BASEs are necessary.

https://codereview.chromium.org/2654693003/diff/80001/services/ui/surfaces/BU...
File services/ui/surfaces/BUILD.gn (right):

https://codereview.chromium.org/2654693003/diff/80001/services/ui/surfaces/BU...
services/ui/surfaces/BUILD.gn:19: "//cc/surfaces:surfaces",
This should be "//cc/surfaces" like it was before, ditto below.

[xing.xu, 2017-01-25 16:21:33]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 16:22:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xing.xu, 2017-01-25 16:24:34]

The CQ bit was unchecked by xing.xu@intel.com

[xing.xu, 2017-01-25 16:24:41]

The CQ bit was checked by xing.xu@intel.com

[xing.xu, 2017-01-25 16:24:42]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/2654693003/#ps120001
(title: "Refactor code")

[commit-bot: I haz the power, 2017-01-25 16:24:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 16:29:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 16:29:58]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jam, 2017-01-25 18:37:50]

Which files do you want me to review?

[xing.xu, 2017-01-25 22:48:16]

On 2017/01/25 18:37:50, jam wrote:
> Which files do you want me to review?

File components/display_compositor/DEPS.
@jam

[xing.xu, 2017-01-25 22:49:29]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 22:50:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-01-25 23:56:58]

lgtm

[Fady Samuel, 2017-01-25 23:57:49]

fsamuel@chromium.org changed reviewers:
+ danakj@chromium.org

[Fady Samuel, 2017-01-25 23:57:50]

+danakj@ for components/display_compositor.

[xing.xu, 2017-01-26 00:25:44]

https://codereview.chromium.org/2654693003/diff/80001/components/display_comp...
File components/display_compositor/gpu_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2654693003/diff/80001/components/display_comp...
components/display_compositor/gpu_compositor_frame_sink.cc:61:
surface_tracker_.UpdateReferences(local_frame_id,
On 2017/01/25 15:54:33, kylechar wrote:
> Can you add the following comment:
> 
> // TODO(kylechar): Move adding top-level root references to
> GpuDisplayCompositorFrameSink.

Acknowledged.

https://codereview.chromium.org/2654693003/diff/80001/components/display_comp...
File components/display_compositor/gpu_compositor_frame_sink.h (right):

https://codereview.chromium.org/2654693003/diff/80001/components/display_comp...
components/display_compositor/gpu_compositor_frame_sink.h:30: : public
NON_EXPORTED_BASE(cc::CompositorFrameSinkSupportClient),
On 2017/01/25 15:54:33, kylechar wrote:
> I don't think any of these NON_EXPORTED_BASEs are necessary.

This is to avoid c4275-warning in windows dbg build. 

Reference for c4275-warning:
http://stackoverflow.com/questions/5207765/c4275-warning-in-visual-studio
https://msdn.microsoft.com/en-us/library/3tdb471s.aspx 

win_chromium_compile_dbg_ng fail with c4275-warning:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com...

[Fady Samuel, 2017-01-26 00:26:53]

https://codereview.chromium.org/2654693003/diff/80001/components/display_comp...
File components/display_compositor/gpu_compositor_frame_sink.h (right):

https://codereview.chromium.org/2654693003/diff/80001/components/display_comp...
components/display_compositor/gpu_compositor_frame_sink.h:30: : public
NON_EXPORTED_BASE(cc::CompositorFrameSinkSupportClient),
On 2017/01/26 00:25:44, xing.xu wrote:
> On 2017/01/25 15:54:33, kylechar wrote:
> > I don't think any of these NON_EXPORTED_BASEs are necessary.
> 
> This is to avoid c4275-warning in windows dbg build. 
> 
> Reference for c4275-warning:
> http://stackoverflow.com/questions/5207765/c4275-warning-in-visual-studio
> https://msdn.microsoft.com/en-us/library/3tdb471s.aspx 
> 
> win_chromium_compile_dbg_ng fail with c4275-warning:
>
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com...

I think you might only need it for cc::CompositorFrameSinkSupportClient.

[xing.xu, 2017-01-26 00:57:30]

On 2017/01/26 00:26:53, Fady Samuel wrote:
>
https://codereview.chromium.org/2654693003/diff/80001/components/display_comp...
> File components/display_compositor/gpu_compositor_frame_sink.h (right):
If not apply NON_EXPORTED_BASEs on  cc::CompositorFrameSinkSupportClient and
cc::mojom::MojoCompositorFrameSink and cc::mojom::MojoCompositorFrameSinkPrivate
and cc::mojom::DisplayPrivate, will report:
warning C4275: non dll-interface class 'cc::CompositorFrameSinkSupportClient'
used as base for dll-interface class
'display_compositor::GpuCompositorFrameSink'
warning C4275: non dll-interface class 'cc::mojom::MojoCompositorFrameSink' used
as base for dll-interface class 'display_compositor::GpuCompositorFrameSink'
warning C4275: non dll-interface class
'cc::mojom::MojoCompositorFrameSinkPrivate' used as base for dll-interface class
'display_compositor::GpuCompositorFrameSink'
warning C4275: non dll-interface class 'cc::mojom::DisplayPrivate' used as base
for dll-interface class 'display_compositor::GpuDisplayCompositorFrameSink'

Reference: 
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com...


> 
>
https://codereview.chromium.org/2654693003/diff/80001/components/display_comp...
> components/display_compositor/gpu_compositor_frame_sink.h:30: : public
> NON_EXPORTED_BASE(cc::CompositorFrameSinkSupportClient),
> On 2017/01/26 00:25:44, xing.xu wrote:
> > On 2017/01/25 15:54:33, kylechar wrote:
> > > I don't think any of these NON_EXPORTED_BASEs are necessary.
> > 
> > This is to avoid c4275-warning in windows dbg build. 
> > 
> > Reference for c4275-warning:
> > http://stackoverflow.com/questions/5207765/c4275-warning-in-visual-studio
> > https://msdn.microsoft.com/en-us/library/3tdb471s.aspx 
> > 
> > win_chromium_compile_dbg_ng fail with c4275-warning:
> >
>
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com...
> 
> I think you might only need it for cc::CompositorFrameSinkSupportClient.

[commit-bot: I haz the power, 2017-01-26 02:34:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 02:34:11]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[xing.xu, 2017-01-26 02:38:59]

The CQ bit was checked by xing.xu@intel.com

[commit-bot: I haz the power, 2017-01-26 02:40:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 04:16:23]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1485398339689210,
"parent_rev": "46c207422a4667f35177488a6af0e90dfbe03532", "commit_rev":
"81183e45cf14c416dfce69b990a0c71a4e1c3399"}

[commit-bot: I haz the power, 2017-01-26 04:17:05]

Description was changed from

==========
Decouple GpuCompositorFrameSink from DisplayCompositor

In order to reuse GpuCompositorFrameSink in other parts of Chrome 
(e.g. OffscreenCanvas), this CL decouples 
GpuCompositorFrameSinkSupport from DisplayCompositor.

This CL also moves GpuCompositorFrameSInk out of 
services/ui/surfaces for now as well because we would like to use 
this code in Chrome and this is currently an incomplete internal
implementation detail of Mus. Once code is unified between Chrome
and Mus, components/display_compositor can probably move to 
services/ui/gpu/display_compositor.

BUG=683735
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Decouple GpuCompositorFrameSink from DisplayCompositor

In order to reuse GpuCompositorFrameSink in other parts of Chrome 
(e.g. OffscreenCanvas), this CL decouples 
GpuCompositorFrameSinkSupport from DisplayCompositor.

This CL also moves GpuCompositorFrameSInk out of 
services/ui/surfaces for now as well because we would like to use 
this code in Chrome and this is currently an incomplete internal
implementation detail of Mus. Once code is unified between Chrome
and Mus, components/display_compositor can probably move to 
services/ui/gpu/display_compositor.

BUG=683735
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2654693003
Cr-Commit-Position: refs/heads/master@{#446223}
Committed:
https://chromium.googlesource.com/chromium/src/+/81183e45cf14c416dfce69b990a0...
==========

[commit-bot: I haz the power, 2017-01-26 04:17:06]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/81183e45cf14c416dfce69b990a0...

[Dan Beam, 2017-01-26 05:28:18]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2651213004/ by dbeam@chromium.org.

The reason for reverting is: Broke Win 64 builder's compile step:
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/7950

[23910/48389] CXX
obj/content/app/content_main_runner_child/content_main_runner.obj
FAILED: obj/content/app/content_main_runner_child/content_main_runner.obj 
ninja -t msvc -e environment.x64 -- C:\b\c\cipd\goma/gomacc.exe
"C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64/cl.exe"
/nologo /showIncludes /FC
@obj/content/app/content_main_runner_child/content_main_runner.obj.rsp /c
../../content/app/content_main_runner.cc
/Foobj/content/app/content_main_runner_child/content_main_runner.obj
/Fd"obj/content/app/content_main_runner_child_cc.pdb"
c:\b\c\b\win_x64_archive\src\content\browser\gpu\gpu_process_host.h(32): fatal
error C1083: Cannot open include file:
'services/ui/gpu/interfaces/gpu_host.mojom.h': No such file or directory.

[xing.xu, 2017-01-26 23:58:43]

Description was changed from

==========
Decouple GpuCompositorFrameSink from DisplayCompositor

In order to reuse GpuCompositorFrameSink in other parts of Chrome 
(e.g. OffscreenCanvas), this CL decouples 
GpuCompositorFrameSinkSupport from DisplayCompositor.

This CL also moves GpuCompositorFrameSInk out of 
services/ui/surfaces for now as well because we would like to use 
this code in Chrome and this is currently an incomplete internal
implementation detail of Mus. Once code is unified between Chrome
and Mus, components/display_compositor can probably move to 
services/ui/gpu/display_compositor.

BUG=683735
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2654693003
Cr-Commit-Position: refs/heads/master@{#446223}
Committed:
https://chromium.googlesource.com/chromium/src/+/81183e45cf14c416dfce69b990a0...
==========

to

==========
Decouple GpuCompositorFrameSink from DisplayCompositor

In order to reuse GpuCompositorFrameSink in other parts of Chrome 
(e.g. OffscreenCanvas), this CL decouples 
GpuCompositorFrameSinkSupport from DisplayCompositor.

This CL also moves GpuCompositorFrameSInk out of 
services/ui/surfaces for now as well because we would like to use 
this code in Chrome and this is currently an incomplete internal
implementation detail of Mus. Once code is unified between Chrome
and Mus, components/display_compositor can probably move to 
services/ui/gpu/display_compositor.

BUG=683735
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2654693003
Cr-Commit-Position: refs/heads/master@{#446223}
Committed:
https://chromium.googlesource.com/chromium/src/+/81183e45cf14c416dfce69b990a0...
==========

[xing.xu, 2017-01-26 23:59:10]

The CQ bit was checked by xing.xu@intel.com

[commit-bot: I haz the power, 2017-01-27 00:01:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 02:21:24]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1485475150768760,
"parent_rev": "03d77dd3e66409c87e9654f3db112fe7b298f925", "commit_rev":
"c6c67d47aec05f4dc57da4ac6bd92f617ecac9e1"}

[commit-bot: I haz the power, 2017-01-27 02:21:54]

Description was changed from

==========
Decouple GpuCompositorFrameSink from DisplayCompositor

In order to reuse GpuCompositorFrameSink in other parts of Chrome 
(e.g. OffscreenCanvas), this CL decouples 
GpuCompositorFrameSinkSupport from DisplayCompositor.

This CL also moves GpuCompositorFrameSInk out of 
services/ui/surfaces for now as well because we would like to use 
this code in Chrome and this is currently an incomplete internal
implementation detail of Mus. Once code is unified between Chrome
and Mus, components/display_compositor can probably move to 
services/ui/gpu/display_compositor.

BUG=683735
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2654693003
Cr-Commit-Position: refs/heads/master@{#446223}
Committed:
https://chromium.googlesource.com/chromium/src/+/81183e45cf14c416dfce69b990a0...
==========

to

==========
Decouple GpuCompositorFrameSink from DisplayCompositor

In order to reuse GpuCompositorFrameSink in other parts of Chrome 
(e.g. OffscreenCanvas), this CL decouples 
GpuCompositorFrameSinkSupport from DisplayCompositor.

This CL also moves GpuCompositorFrameSInk out of 
services/ui/surfaces for now as well because we would like to use 
this code in Chrome and this is currently an incomplete internal
implementation detail of Mus. Once code is unified between Chrome
and Mus, components/display_compositor can probably move to 
services/ui/gpu/display_compositor.

BUG=683735
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2654693003
Cr-Original-Commit-Position: refs/heads/master@{#446223}
Committed:
https://chromium.googlesource.com/chromium/src/+/81183e45cf14c416dfce69b990a0...
Review-Url: https://codereview.chromium.org/2654693003
Cr-Commit-Position: refs/heads/master@{#446540}
Committed:
https://chromium.googlesource.com/chromium/src/+/c6c67d47aec05f4dc57da4ac6bd9...
==========

[commit-bot: I haz the power, 2017-01-27 02:21:55]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/c6c67d47aec05f4dc57da4ac6bd9...