Make scroll translation transform nodes reference scroll nodes

Make scroll translation transform nodes reference scroll nodes

This is the first of two patches to move scroll tree ownership to
the transform nodes that are used for scroll translation. This will
let us track just the transform, effect, and clip trees for geometry
mapping purposes without worrying about scroll nodes which do not
affect compositing decisions on their own (only through their
associated scroll translation transform nodes).

This patch removes the scroll node pointer to a transform node and
adds a pointer from transform nodes to scroll nodes. The compositing
element id has also been moved from the scroll node to the associated
transform node to remove redundancy.

BUG=683774
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2651093003
Cr-Commit-Position: refs/heads/master@{#446545}
Committed: https://chromium.googlesource.com/chromium/src/+/231ba29e221aa7ff9e7839c5bae0a05afbff28dc

[pdr., 2017-01-25 06:35:11]

Description was changed from

==========
Make scroll translation transform nodes reference scroll nodes

This is the first of two patches to move scroll tree ownership to
the transform nodes that are used for scroll translation. This will
let us track just the transform, effect, and clip trees for geometry
mapping purposes without worrying about scroll nodes which do not
affect compositing decisions on their own (only through their
associated scroll translation transform nodes).

This patch removes the scroll node pointer to a transform node and
adds a pointer from transform nodes to scroll nodes. The compositing
element id has also been moved from the scroll node to the associated
transform node to remove redundancy.

BUG=683774
==========

to

==========
Make scroll translation transform nodes reference scroll nodes

This is the first of two patches to move scroll tree ownership to
the transform nodes that are used for scroll translation. This will
let us track just the transform, effect, and clip trees for geometry
mapping purposes without worrying about scroll nodes which do not
affect compositing decisions on their own (only through their
associated scroll translation transform nodes).

This patch removes the scroll node pointer to a transform node and
adds a pointer from transform nodes to scroll nodes. The compositing
element id has also been moved from the scroll node to the associated
transform node to remove redundancy.

BUG=683774
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2017-01-25 06:36:16]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 06:36:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 08:19:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 08:19:07]

Dry run: This issue passed the CQ dry run.

[pdr., 2017-01-25 18:13:19]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org, wkorman@chromium.org

[pdr., 2017-01-25 18:16:21]

A small change buried in this patch is moving compositor element ids off
ScrollPaintPropertyNode and onto TransformPaintPropertyNode because the final
design will have scroll nodes hanging off transform nodes, and two ids seemed
redundant. This does require adjusting the compositor element id maps in PAC
though, so I'd be okay with either approach (ids on transforms and scrolls, or
just on transforms like this patch).

[chrishtr, 2017-01-25 19:45:09]

lgtm

LGTM, but I think Walter had a comment/concern about where to store compositor
element ids.

[pdr., 2017-01-25 19:51:09]

https://codereview.chromium.org/2651093003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/ScrollPaintPropertyNode.h
(right):

https://codereview.chromium.org/2651093003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/ScrollPaintPropertyNode.h:25:
// translation.
Walter pointed out that we should put a comment here noting that the scroll
paint property tree differs from the other trees since it is (or will be)
embedded in the transform tree. We could even consider naming this
RareScrollNode or something like that.

[wkorman, 2017-01-25 19:56:37]

lgtm

[pdr., 2017-01-26 19:29:31]

On 2017/01/25 at 19:56:37, wkorman wrote:
> lgtm

I like how the followup turned out (https://codereview.chromium.org/2657863004)
so I'm going to go ahead and land this.

[pdr., 2017-01-26 19:29:34]

The CQ bit was checked by pdr@chromium.org

[pdr., 2017-01-26 19:29:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2651093003/#ps10016
(title: "Add note about scroll tree differences")

[commit-bot: I haz the power, 2017-01-26 19:30:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2017-01-26 20:02:55]

pdr@chromium.org changed reviewers:
+ trchen@chromium.org

[commit-bot: I haz the power, 2017-01-26 23:25:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 23:25:13]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pdr., 2017-01-27 00:40:35]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-01-27 00:41:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 02:36:57]

CQ is committing da patch.

Bot data: {"patchset_id": 10016, "attempt_start_ts": 1485477635216610,
"parent_rev": "da30844d66359a897654cbec17e1573b838a625d", "commit_rev":
"231ba29e221aa7ff9e7839c5bae0a05afbff28dc"}

[commit-bot: I haz the power, 2017-01-27 02:37:34]

Description was changed from

==========
Make scroll translation transform nodes reference scroll nodes

This is the first of two patches to move scroll tree ownership to
the transform nodes that are used for scroll translation. This will
let us track just the transform, effect, and clip trees for geometry
mapping purposes without worrying about scroll nodes which do not
affect compositing decisions on their own (only through their
associated scroll translation transform nodes).

This patch removes the scroll node pointer to a transform node and
adds a pointer from transform nodes to scroll nodes. The compositing
element id has also been moved from the scroll node to the associated
transform node to remove redundancy.

BUG=683774
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Make scroll translation transform nodes reference scroll nodes

This is the first of two patches to move scroll tree ownership to
the transform nodes that are used for scroll translation. This will
let us track just the transform, effect, and clip trees for geometry
mapping purposes without worrying about scroll nodes which do not
affect compositing decisions on their own (only through their
associated scroll translation transform nodes).

This patch removes the scroll node pointer to a transform node and
adds a pointer from transform nodes to scroll nodes. The compositing
element id has also been moved from the scroll node to the associated
transform node to remove redundancy.

BUG=683774
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2651093003
Cr-Commit-Position: refs/heads/master@{#446545}
Committed:
https://chromium.googlesource.com/chromium/src/+/231ba29e221aa7ff9e7839c5bae0...
==========

[commit-bot: I haz the power, 2017-01-27 02:37:37]

Committed patchset #2 (id:10016) as
https://chromium.googlesource.com/chromium/src/+/231ba29e221aa7ff9e7839c5bae0...