Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PropertyTreeStateTest.cpp

Issue 2651093003: Make scroll translation transform nodes reference scroll nodes (Closed)
Patch Set: Add note about scroll tree differences Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/PropertyTreeStateTest.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeStateTest.cpp b/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeStateTest.cpp
index 1eceacf095dd3df465f23136baec1caef6b10520..3065dda6233b3a1adeac973a0e8b99e392e8e616 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeStateTest.cpp
+++ b/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeStateTest.cpp
@@ -160,24 +160,13 @@ TEST_F(PropertyTreeStateTest, CompositorElementIdNoElementIdOnAnyNode) {
EXPECT_EQ(CompositorElementId(), state.compositorElementId());
}
-TEST_F(PropertyTreeStateTest, CompositorElementIdWithElementIdOnScrollNode) {
- CompositorElementId expectedCompositorElementId = CompositorElementId(2, 0);
- RefPtr<ScrollPaintPropertyNode> scroll = ScrollPaintPropertyNode::create(
- ScrollPaintPropertyNode::root(), TransformPaintPropertyNode::root(),
- IntSize(), IntSize(), true, false, 0, expectedCompositorElementId);
- PropertyTreeState state(TransformPaintPropertyNode::root(),
- ClipPaintPropertyNode::root(),
- EffectPaintPropertyNode::root(), scroll.get());
- EXPECT_EQ(expectedCompositorElementId, state.compositorElementId());
-}
-
TEST_F(PropertyTreeStateTest, CompositorElementIdWithElementIdOnTransformNode) {
CompositorElementId expectedCompositorElementId = CompositorElementId(2, 0);
RefPtr<TransformPaintPropertyNode> transform =
- TransformPaintPropertyNode::create(TransformPaintPropertyNode::root(),
- TransformationMatrix(), FloatPoint3D(),
- false, 0, CompositingReasonNone,
- expectedCompositorElementId);
+ TransformPaintPropertyNode::create(
+ TransformPaintPropertyNode::root(), TransformationMatrix(),
+ FloatPoint3D(), nullptr, false, 0, CompositingReasonNone,
+ expectedCompositorElementId);
PropertyTreeState state(transform.get(), ClipPaintPropertyNode::root(),
EffectPaintPropertyNode::root(),
ScrollPaintPropertyNode::root());
@@ -198,15 +187,14 @@ TEST_F(PropertyTreeStateTest, CompositorElementIdWithElementIdOnEffectNode) {
}
TEST_F(PropertyTreeStateTest, CompositorElementIdWithElementIdOnMultipleNodes) {
- CompositorElementId expectedCompositorElementId = CompositorElementId(2, 0);
RefPtr<ScrollPaintPropertyNode> scroll = ScrollPaintPropertyNode::create(
- ScrollPaintPropertyNode::root(), TransformPaintPropertyNode::root(),
- IntSize(), IntSize(), true, false, 0, expectedCompositorElementId);
+ ScrollPaintPropertyNode::root(), IntSize(), IntSize(), true, false, 0);
+ CompositorElementId expectedCompositorElementId = CompositorElementId(2, 0);
RefPtr<TransformPaintPropertyNode> transform =
- TransformPaintPropertyNode::create(TransformPaintPropertyNode::root(),
- TransformationMatrix(), FloatPoint3D(),
- false, 0, CompositingReasonNone,
- expectedCompositorElementId);
+ TransformPaintPropertyNode::create(
+ TransformPaintPropertyNode::root(), TransformationMatrix(),
+ FloatPoint3D(), nullptr, false, 0, CompositingReasonNone,
+ expectedCompositorElementId);
RefPtr<EffectPaintPropertyNode> effect = EffectPaintPropertyNode::create(
EffectPaintPropertyNode::root(), TransformPaintPropertyNode::root(),
ClipPaintPropertyNode::root(), CompositorFilterOperations(), 1.0,

Powered by Google App Engine
This is Rietveld 408576698