third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp - Issue 2651093003: Make scroll translation transform nodes reference scroll nodes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp

Issue 2651093003: Make scroll translation transform nodes reference scroll nodes (Closed)

Patch Set: Add note about scroll tree differences Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp ('k') | third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp

index b91dff158a79ba1cd0bad6b4114d72b5a05a2b13..38386c136ec51f8c5e77ab176e423cac6f76b50a 100644

--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp

@@ -128,8 +128,8 @@ TEST_P(PaintPropertyTreePrinterTest, SimpleScrollTreePath) {

const auto* scrollObjectProperties = scrollObject->paintProperties();

String scrollPathAsString = scrollObjectProperties->scroll()->toTreeString();

EXPECT_THAT(scrollPathAsString.ascii().data(),

- testing::MatchesRegex("root .* scroll.*"

- " .* scroll.*"));

+ testing::MatchesRegex("root .* parent.*"

+ " .* parent.*"));

}

} // namespace blink