Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.cpp

Issue 2651093003: Make scroll translation transform nodes reference scroll nodes (Closed)
Patch Set: Add note about scroll tree differences Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.cpp b/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.cpp
index c350165afdf9f5b5e9b38841ea35bf4682d9d76d..b8c70c0aa8ad63367ed764dfd030d0907f53f2d1 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.cpp
+++ b/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.cpp
@@ -30,20 +30,14 @@ bool isAncestorOf(const PropertyNode* ancestor, const PropertyNode* child) {
}
const CompositorElementId PropertyTreeState::compositorElementId() const {
-// Zero or more of the scroll, effect or transform nodes could have a
-// compositor element id. The order doesn't matter as the element id should be
-// the same on all that have a non-default CompositorElementId.
+// The effect or transform nodes could have a compositor element id. The order
+// doesn't matter as the element id should be the same on all that have a
+// non-default CompositorElementId.
#if DCHECK_IS_ON()
CompositorElementId expectedElementId;
if (CompositorElementId actualElementId = effect()->compositorElementId()) {
expectedElementId = actualElementId;
}
- if (CompositorElementId actualElementId = scroll()->compositorElementId()) {
- if (!expectedElementId)
- expectedElementId = actualElementId;
- else
- DCHECK_EQ(expectedElementId, actualElementId);
- }
if (CompositorElementId actualElementId =
transform()->compositorElementId()) {
if (expectedElementId)
@@ -52,8 +46,6 @@ const CompositorElementId PropertyTreeState::compositorElementId() const {
#endif
if (effect()->compositorElementId())
return effect()->compositorElementId();
- if (scroll()->compositorElementId())
- return scroll()->compositorElementId();
if (transform()->compositorElementId())
return transform()->compositorElementId();
return CompositorElementId();

Powered by Google App Engine
This is Rietveld 408576698