Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 2650623002: Use explicit WebString conversions in autofill (Closed)

Created:
3 years, 11 months ago by kinuko
Modified:
3 years, 11 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, jam, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use explicit WebString conversions in autofill As we're deprecating implicit conversions for WebString <-> string16 replace them with explicit methods. (See crbug.com/667131 for more details) Also in some files WebString implicit conversions seem to be used just to get base::string16, this CL also replaces them with base's string16 conversion methods. BUG=667131 Review-Url: https://codereview.chromium.org/2650623002 Cr-Commit-Position: refs/heads/master@{#445569} Committed: https://chromium.googlesource.com/chromium/src/+/0073e7c8e416685bfa479638a2ae05f8b217d434

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -142 lines) Patch
M chrome/renderer/autofill/form_autocomplete_browsertest.cc View 2 chunks +12 lines, -16 lines 0 comments Download
M chrome/renderer/autofill/form_autofill_browsertest.cc View 1 8 chunks +24 lines, -23 lines 0 comments Download
M chrome/renderer/autofill/password_autofill_agent_browsertest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/renderer/autofill/password_generation_agent_browsertest.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 4 chunks +13 lines, -9 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 1 16 chunks +27 lines, -26 lines 0 comments Download
M components/autofill/content/renderer/form_cache.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M components/autofill/content/renderer/form_classifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 10 chunks +18 lines, -16 lines 0 comments Download
M components/autofill/content/renderer/password_form_conversion_utils.cc View 9 chunks +16 lines, -15 lines 0 comments Download
M components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/renderer/password_generation_agent.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M components/autofill/content/renderer/renderer_save_password_progress_logger.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
kinuko
Evan, can you review? Mostly mechanical changes only.
3 years, 11 months ago (2017-01-23 04:27:03 UTC) #9
Evan Stade
spot checked some files, mostly rubbery lgtm
3 years, 11 months ago (2017-01-23 16:07:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650623002/20001
3 years, 11 months ago (2017-01-24 00:36:41 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 00:43:17 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0073e7c8e416685bfa479638a2ae...

Powered by Google App Engine
This is Rietveld 408576698