components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc - Issue 2650623002: Use explicit WebString conversions in autofill

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

Issue 2650623002: Use explicit WebString conversions in autofill (Closed)

Patch Set: . Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/password_form_conversion_utils.cc ('k') | components/autofill/content/renderer/password_generation_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

diff --git a/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc b/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

index 08b1988e1580d251e70db6a29d12e5fdc0a5dcd3..ead27968a8431033877ad2386288d0e4a16eead7 100644

--- a/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

+++ b/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

@@ -186,7 +186,7 @@ class MAYBE_PasswordFormConversionUtilsTest : public content::RenderViewTest {

if (input_element->hasAttribute("set-activated-submit"))

input_element->setActivatedSubmit(true);

if (with_user_input) {

- const base::string16 element_value = input_element->value();

+ const base::string16 element_value = input_element->value().utf16();

user_input[control_elements[i]] =

std::make_pair(base::MakeUnique<base::string16>(element_value), 0U);

}