Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6080)

Unified Diff: chrome/renderer/autofill/password_autofill_agent_browsertest.cc

Issue 2650623002: Use explicit WebString conversions in autofill (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/autofill/password_autofill_agent_browsertest.cc
diff --git a/chrome/renderer/autofill/password_autofill_agent_browsertest.cc b/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
index c598b756574250296bb308620d008aedeaab3fe4..55aa61aad3d69fec9c38ff4569ce5904da281ccc 100644
--- a/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
+++ b/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
@@ -671,7 +671,7 @@ TEST_F(PasswordAutofillAgentTest, NoInitialAutocompleteForReadOnlyPassword) {
// matches.
TEST_F(PasswordAutofillAgentTest,
AutocompletePasswordForReadonlyUsernameMatched) {
- username_element_.setValue(username3_);
+ username_element_.setValue(WebString::fromUTF16(username3_));
SetElementReadOnly(username_element_, true);
// Filled even though username is not the preferred match.
@@ -1189,7 +1189,7 @@ TEST_F(PasswordAutofillAgentTest, ClearPreviewWithPasswordAutofilled) {
EXPECT_TRUE(username_element_.value().isEmpty());
EXPECT_TRUE(username_element_.suggestedValue().isEmpty());
EXPECT_FALSE(username_element_.isAutofilled());
- EXPECT_EQ(ASCIIToUTF16("sec"), password_element_.value());
+ EXPECT_EQ(ASCIIToUTF16("sec"), password_element_.value().utf16());
EXPECT_TRUE(password_element_.suggestedValue().isEmpty());
EXPECT_TRUE(password_element_.isAutofilled());
CheckUsernameSelection(0, 0);
@@ -1215,7 +1215,7 @@ TEST_F(PasswordAutofillAgentTest, ClearPreviewWithUsernameAutofilled) {
EXPECT_TRUE(
password_autofill_agent_->DidClearAutofillSelection(username_element_));
- EXPECT_EQ(ASCIIToUTF16("ali"), username_element_.value());
+ EXPECT_EQ(ASCIIToUTF16("ali"), username_element_.value().utf16());
EXPECT_TRUE(username_element_.suggestedValue().isEmpty());
EXPECT_TRUE(username_element_.isAutofilled());
EXPECT_TRUE(password_element_.value().isEmpty());
@@ -1247,10 +1247,10 @@ TEST_F(PasswordAutofillAgentTest,
EXPECT_TRUE(
password_autofill_agent_->DidClearAutofillSelection(username_element_));
- EXPECT_EQ(ASCIIToUTF16("ali"), username_element_.value());
+ EXPECT_EQ(ASCIIToUTF16("ali"), username_element_.value().utf16());
EXPECT_TRUE(username_element_.suggestedValue().isEmpty());
EXPECT_TRUE(username_element_.isAutofilled());
- EXPECT_EQ(ASCIIToUTF16("sec"), password_element_.value());
+ EXPECT_EQ(ASCIIToUTF16("sec"), password_element_.value().utf16());
EXPECT_TRUE(password_element_.suggestedValue().isEmpty());
EXPECT_TRUE(password_element_.isAutofilled());
CheckUsernameSelection(3, 3);
@@ -1805,7 +1805,7 @@ TEST_F(PasswordAutofillAgentTest, ShowPopupOnEmptyPasswordField) {
SimulateSuggestionChoiceOfUsernameAndPassword(
password_element_, base::string16(), ASCIIToUTF16(kAlicePassword));
CheckSuggestions(std::string(), false);
- EXPECT_EQ(ASCIIToUTF16(kAlicePassword), password_element_.value());
+ EXPECT_EQ(ASCIIToUTF16(kAlicePassword), password_element_.value().utf16());
EXPECT_TRUE(password_element_.isAutofilled());
}
@@ -1836,7 +1836,7 @@ TEST_F(PasswordAutofillAgentTest, ShowPopupOnAutofilledPasswordField) {
SimulateSuggestionChoiceOfUsernameAndPassword(
password_element_, base::string16(), ASCIIToUTF16(kAlicePassword));
CheckSuggestions(std::string(), false);
- EXPECT_EQ(ASCIIToUTF16(kAlicePassword), password_element_.value());
+ EXPECT_EQ(ASCIIToUTF16(kAlicePassword), password_element_.value().utf16());
EXPECT_TRUE(password_element_.isAutofilled());
}

Powered by Google App Engine
This is Rietveld 408576698