Use explicit WebString conversions in autofill

chrome/renderer/autofill/password_generation_agent_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string.h>
 
 #include <memory>
 
 #include "base/macros.h"
 #include "base/run_loop.h"
@@ skipping 314 matching lines @@
   WebInputElement second_password_element = element.to<WebInputElement>();
 
   // Both password fields should be empty.
   EXPECT_TRUE(first_password_element.value().isNull());
   EXPECT_TRUE(second_password_element.value().isNull());
 
   base::string16 password = base::ASCIIToUTF16("random_password");
   password_generation_->GeneratedPasswordAccepted(password);
 
   // Password fields are filled out and set as being autofilled.
-  EXPECT_EQ(password, first_password_element.value());
-  EXPECT_EQ(password, second_password_element.value());
+  EXPECT_EQ(password, first_password_element.value().utf16());
+  EXPECT_EQ(password, second_password_element.value().utf16());
   EXPECT_TRUE(first_password_element.isAutofilled());
   EXPECT_TRUE(second_password_element.isAutofilled());
 
   // Make sure onchange events are called.
   int first_onchange_called = -1;
   int second_onchange_called = -1;
   ASSERT_TRUE(
       ExecuteJavaScriptAndReturnIntValue(
           base::ASCIIToUTF16("firstOnChangeCalled ? 1 : 0"),
           &first_onchange_called));
@@ skipping 24 matching lines @@
   ASSERT_FALSE(element.isNull());
   WebInputElement first_password_element = element.to<WebInputElement>();
   element = document.getElementById(WebString::fromUTF8("second_password"));
   ASSERT_FALSE(element.isNull());
   WebInputElement second_password_element = element.to<WebInputElement>();
 
   base::string16 password = base::ASCIIToUTF16("random_password");
   password_generation_->GeneratedPasswordAccepted(password);
 
   // Passwords start out the same.
-  EXPECT_EQ(password, first_password_element.value());
-  EXPECT_EQ(password, second_password_element.value());
+  EXPECT_EQ(password, first_password_element.value().utf16());
+  EXPECT_EQ(password, second_password_element.value().utf16());
 
   // After editing the first field they are still the same.
   std::string edited_password_ascii = "edited_password";
   SimulateUserInputChangeForElement(&first_password_element,
                                     edited_password_ascii);
   base::string16 edited_password = base::ASCIIToUTF16(edited_password_ascii);
-  EXPECT_EQ(edited_password, first_password_element.value());
-  EXPECT_EQ(edited_password, second_password_element.value());
+  EXPECT_EQ(edited_password, first_password_element.value().utf16());
+  EXPECT_EQ(edited_password, second_password_element.value().utf16());
 
   fake_driver_.reset_called_password_no_longer_generated();
 
   // Verify that password mirroring works correctly even when the password
   // is deleted.
   SimulateUserInputChangeForElement(&first_password_element, std::string());
-  EXPECT_EQ(base::string16(), first_password_element.value());
-  EXPECT_EQ(base::string16(), second_password_element.value());
+  EXPECT_EQ(base::string16(), first_password_element.value().utf16());
+  EXPECT_EQ(base::string16(), second_password_element.value().utf16());
 
   // Should have notified the browser that the password is no longer generated
   // and trigger generation again.
   base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(fake_driver_.called_password_no_longer_generated());
   EXPECT_TRUE(GetCalledShowPasswordGenerationPopup());
 }
 
 TEST_F(PasswordGenerationAgentTest, BlacklistedTest) {
   // Did not receive not blacklisted message. Don't show password generation
@@ skipping 308 matching lines @@
                                    base::string16());
 }
 
 TEST_F(PasswordGenerationAgentTest, FormClassifierDisabled) {
   LoadHTMLWithUserGesture(kSigninFormHTML);
   ExpectFormClassifierVoteReceived(false /* vote is not expected */,
                                    base::string16());
 }
 
 }  // namespace autofill