WebUI: Undo some usages of ES6 features that break uglify.

WebUI: Undo some usages of ES6 features that break uglify.

for..of, let and backticks are currently not supported by uglify. Revert those
usages until uglify is updated to its ES6-aware version.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2649663002
Cr-Commit-Position: refs/heads/master@{#445447}
Committed: https://chromium.googlesource.com/chromium/src/+/a6dfd6a74d424a329c6d46d736fca7552e6fb68b

[dpapad, 2017-01-21 00:37:20]

Description was changed from

==========
WebUI: Undo some usages of ES6 features that break uglify.

for..of, let and backticks are currently not supported by uglify. Revert those
usages until uglify is updated to its ES6-aware version.

BUG=673825
==========

to

==========
WebUI: Undo some usages of ES6 features that break uglify.

for..of, let and backticks are currently not supported by uglify. Revert those
usages until uglify is updated to its ES6-aware version.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-01-21 00:39:42]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-21 00:40:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-01-21 00:47:49]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2017-01-21 00:47:50]

https://codereview.chromium.org/2649663002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/route.js (right):

https://codereview.chromium.org/2649663002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/route.js:214: var routeObservers_ = new Set();
need to make this an array or something

[commit-bot: I haz the power, 2017-01-21 00:51:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 00:51:35]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[dpapad, 2017-01-21 00:55:49]

https://codereview.chromium.org/2649663002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/route.js (right):

https://codereview.chromium.org/2649663002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/route.js:214: var routeObservers_ = new Set();
On 2017/01/21 at 00:47:50, Dan Beam (slow - converging) wrote:
> need to make this an array or something

Done, with Array.from(). Let's see if the compiler knows about it.

[dpapad, 2017-01-21 01:01:55]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[dpapad, 2017-01-21 01:02:47]

https://codereview.chromium.org/2649663002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/route.js (right):

https://codereview.chromium.org/2649663002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/route.js:214: var routeObservers_ = new Set();
On 2017/01/21 at 00:55:49, dpapad wrote:
> On 2017/01/21 at 00:47:50, Dan Beam (slow - converging) wrote:
> > need to make this an array or something
> 
> Done, with Array.from(). Let's see if the compiler knows about it.

Changed to Set#forEach, to avoid the unnecessary conversion to Array.

[commit-bot: I haz the power, 2017-01-21 01:02:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-01-21 01:05:49]

lgtm

https://codereview.chromium.org/2649663002/diff/60001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/cr_scrollable_behavior.js (right):

https://codereview.chromium.org/2649663002/diff/60001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/cr_scrollable_behavior.js:54: for (var i = 0; i <
scrollableElements.length; i++)
nit: curlies

[dpapad, 2017-01-21 01:10:53]

https://codereview.chromium.org/2649663002/diff/60001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/cr_scrollable_behavior.js (right):

https://codereview.chromium.org/2649663002/diff/60001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/cr_scrollable_behavior.js:54: for (var i = 0; i <
scrollableElements.length; i++)
On 2017/01/21 at 01:05:49, Dan Beam (slow - converging) wrote:
> nit: curlies

Done.

[dpapad, 2017-01-21 01:33:43]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-21 01:34:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 03:10:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 03:10:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stevenjb, 2017-01-21 19:09:10]

stevenjb@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2017-01-21 19:09:11]

https://codereview.chromium.org/2649663002/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/settings/languages_page/languages.js (right):

https://codereview.chromium.org/2649663002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/settings/languages_page/languages.js:292: for (var j =
0; j < supportedInputMethods.length; i++) {
j++

[dpapad, 2017-01-23 18:17:53]

https://codereview.chromium.org/2649663002/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/settings/languages_page/languages.js (right):

https://codereview.chromium.org/2649663002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/settings/languages_page/languages.js:292: for (var j =
0; j < supportedInputMethods.length; i++) {
On 2017/01/21 at 19:09:11, stevenjb wrote:
> j++

Thanks for catching this, fixed.

[dpapad, 2017-01-23 18:17:56]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2017-01-23 18:17:56]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2649663002/#ps120001
(title: "Fix i->j")

[commit-bot: I haz the power, 2017-01-23 18:18:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 19:58:22]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1485195476020820,
"parent_rev": "de98564dd01fc504893e37a08dd33ababfdf0532", "commit_rev":
"a6dfd6a74d424a329c6d46d736fca7552e6fb68b"}

[commit-bot: I haz the power, 2017-01-23 19:59:16]

Description was changed from

==========
WebUI: Undo some usages of ES6 features that break uglify.

for..of, let and backticks are currently not supported by uglify. Revert those
usages until uglify is updated to its ES6-aware version.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
WebUI: Undo some usages of ES6 features that break uglify.

for..of, let and backticks are currently not supported by uglify. Revert those
usages until uglify is updated to its ES6-aware version.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2649663002
Cr-Commit-Position: refs/heads/master@{#445447}
Committed:
https://chromium.googlesource.com/chromium/src/+/a6dfd6a74d424a329c6d46d736fc...
==========

[commit-bot: I haz the power, 2017-01-23 19:59:18]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/a6dfd6a74d424a329c6d46d736fc...