chrome/browser/resources/settings/languages_page/add_languages_dialog.js - Issue 2649663002: WebUI: Undo some usages of ES6 features that break uglify.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/languages_page/add_languages_dialog.js

Issue 2649663002: WebUI: Undo some usages of ES6 features that break uglify. (Closed)

Patch Set: Fix i->j Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/controls/extension_controlled_indicator.js ('k') | chrome/browser/resources/settings/languages_page/languages.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/languages_page/add_languages_dialog.js

diff --git a/chrome/browser/resources/settings/languages_page/add_languages_dialog.js b/chrome/browser/resources/settings/languages_page/add_languages_dialog.js

index 0f67c46ce4206e8ee5b31b6fedc03c51b4008945..8c687d7ea027f571ad410bdfa8a7aba418bd0a1d 100644

--- a/chrome/browser/resources/settings/languages_page/add_languages_dialog.js

+++ b/chrome/browser/resources/settings/languages_page/add_languages_dialog.js

@@ -110,7 +110,8 @@ Polymer({

onActionButtonTap_: function() {

this.$.dialog.close();

- for (var languageCode of this.languagesToAdd_)

- this.languageHelper.enableLanguage(languageCode);

+ this.languagesToAdd_.forEach(function(language) {

+ this.languageHelper.enableLanguage(language);

+ }.bind(this));

});