Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: ui/webui/resources/cr_elements/cr_scrollable_behavior.js

Issue 2649663002: WebUI: Undo some usages of ES6 features that break uglify. (Closed)
Patch Set: Fix i->j Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/webui/resources/cr_elements/cr_scrollable_behavior.js
diff --git a/ui/webui/resources/cr_elements/cr_scrollable_behavior.js b/ui/webui/resources/cr_elements/cr_scrollable_behavior.js
index d0f4b0265ea93def612096690337cea623eef010..5589c18ed448bc8ab46ad12fd051340f5f9d6e78 100644
--- a/ui/webui/resources/cr_elements/cr_scrollable_behavior.js
+++ b/ui/webui/resources/cr_elements/cr_scrollable_behavior.js
@@ -46,13 +46,15 @@ var CrScrollableBehavior = {
// Setup the intial scrolling related classes for each scrollable container.
requestAnimationFrame(function() {
- for (let scrollable of scrollableElements)
- this.updateScroll_(scrollable);
+ for (var i = 0; i < scrollableElements.length; i++)
+ this.updateScroll_(scrollableElements[i]);
}.bind(this));
// Listen to the 'scroll' event for each scrollable container.
- for (let scrollable of scrollableElements)
- scrollable.addEventListener('scroll', this.updateScrollEvent_.bind(this));
+ for (var i = 0; i < scrollableElements.length; i++) {
+ scrollableElements[i].addEventListener(
+ 'scroll', this.updateScrollEvent_.bind(this));
+ }
},
detached: function() {
@@ -69,16 +71,17 @@ var CrScrollableBehavior = {
if (this.intervalId_ !== null)
return; // notifyResize is arelady in progress.
- let nodeList = this.root.querySelectorAll('[scrollable] iron-list');
+ var nodeList = this.root.querySelectorAll('[scrollable] iron-list');
// Use setInterval to avoid initial render / sizing issues.
this.intervalId_ = window.setInterval(function() {
- let unreadyNodes = [];
- for (let node of nodeList) {
+ var unreadyNodes = [];
+ for (var i = 0; i < nodeList.length; i++) {
+ var node = nodeList[i];
if (node.parentNode.scrollHeight == 0) {
unreadyNodes.push(node);
continue;
}
- let ironList = /** @type {!IronListElement} */ (node);
+ var ironList = /** @type {!IronListElement} */ (node);
ironList.notifyResize();
}
if (unreadyNodes.length == 0) {
@@ -96,7 +99,7 @@ var CrScrollableBehavior = {
* @private
*/
updateScrollEvent_: function(event) {
- let scrollable = /** @type {!HTMLElement} */ (event.target);
+ var scrollable = /** @type {!HTMLElement} */ (event.target);
this.updateScroll_(scrollable);
},

Powered by Google App Engine
This is Rietveld 408576698