chrome/browser/resources/settings/settings_page/main_page_behavior.js - Issue 2649663002: WebUI: Undo some usages of ES6 features that break uglify.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/main_page_behavior.js

Issue 2649663002: WebUI: Undo some usages of ES6 features that break uglify. (Closed)

Patch Set: Fix i->j Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_settings.js ('k') | chrome/browser/resources/settings/settings_ui/settings_ui.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page/main_page_behavior.js

diff --git a/chrome/browser/resources/settings/settings_page/main_page_behavior.js b/chrome/browser/resources/settings/settings_page/main_page_behavior.js

index 96631d9d41912865129829a8419f3574be9399ab..8fdf5f7e6e61f2e949d67e6f8acaa3df9fce936d 100644

--- a/chrome/browser/resources/settings/settings_page/main_page_behavior.js

+++ b/chrome/browser/resources/settings/settings_page/main_page_behavior.js

@@ -289,8 +289,8 @@ var MainPageBehaviorImpl = {

toggleOtherSectionsHidden_: function(sectionName, hidden) {

var sections = Polymer.dom(this.root).querySelectorAll(

'settings-section');

- for (var section of sections)

- section.hidden = hidden && (section.section != sectionName);

+ for (var i = 0; i < sections.length; i++)

+ sections[i].hidden = hidden && (sections[i].section != sectionName);

/**