DevTools: convert datagrid and network waterfall sort icons to UI.Icon

DevTools: convert datagrid and network waterfall sort icons to UI.Icon

This patch converts more icons to UI.Icon:
- the "up/down" sort icons on data grid header cells
- the "up/down" sort icon on the network waterfall

BUG=669323
R=dgozman

Review-Url: https://codereview.chromium.org/2649153005
Cr-Commit-Position: refs/heads/master@{#445952}
Committed: https://chromium.googlesource.com/chromium/src/+/f2566bcd386311eb6e0d9e12036b582102687e7d

[lushnikov, 2017-01-24 06:54:09]

please, take a look!

[lushnikov, 2017-01-24 06:54:13]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 06:54:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 08:24:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 08:24:49]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-01-24 20:23:05]

lgtm

https://codereview.chromium.org/2649153005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/networkLogView.css
(left):

https://codereview.chromium.org/2649153005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/networkLogView.css:389:
display: none;
This means the icon is visible all the time, which should not be the case when
sorting by name.

https://codereview.chromium.org/2649153005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/Icon.js (right):

https://codereview.chromium.org/2649153005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/Icon.js:111:
'smallicon-triangle-bottom': {x: -20, y: -98, width: 10, height: 8, spritesheet:
'largeicons', isMask: true},
Should this be triangle-down?

[lushnikov, 2017-01-25 00:06:13]

https://codereview.chromium.org/2649153005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/networkLogView.css
(left):

https://codereview.chromium.org/2649153005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/networkLogView.css:389:
display: none;
On 2017/01/24 20:23:05, dgozman wrote:
> This means the icon is visible all the time, which should not be the case when
> sorting by name.

Yes, it is visible all the time on Canary. I updated the CL so that it gets
hidden via the:

     this._waterfallColumnSortIcon.setIconType('');

https://codereview.chromium.org/2649153005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/Icon.js (right):

https://codereview.chromium.org/2649153005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/Icon.js:111:
'smallicon-triangle-bottom': {x: -20, y: -98, width: 10, height: 8, spritesheet:
'largeicons', isMask: true},
On 2017/01/24 20:23:05, dgozman wrote:
> Should this be triangle-down?

Done.

[lushnikov, 2017-01-25 00:07:35]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-01-25 00:07:35]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2649153005/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2017-01-25 00:08:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-01-25 00:12:49]

On 2017/01/25 00:06:13, lushnikov wrote:
>
https://codereview.chromium.org/2649153005/diff/1/third_party/WebKit/Source/d...
> File third_party/WebKit/Source/devtools/front_end/network/networkLogView.css
> (left):
> 
>
https://codereview.chromium.org/2649153005/diff/1/third_party/WebKit/Source/d...
> third_party/WebKit/Source/devtools/front_end/network/networkLogView.css:389:
> display: none;
> On 2017/01/24 20:23:05, dgozman wrote:
> > This means the icon is visible all the time, which should not be the case
when
> > sorting by name.
> 
> Yes, it is visible all the time on Canary. I updated the CL so that it gets
> hidden via the:
> 
>      this._waterfallColumnSortIcon.setIconType('');
Should merge it then!

[lushnikov, 2017-01-25 00:13:22]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2017-01-25 00:35:57]

Description was changed from

==========
DevTools: convert datagrid and network waterfall sort icons to UI.Icon

This patch converts more icons to UI.Icon:
- the "up/down" sort icons on data grid header cells
- the "up/down" sort icon on the network waterfall

Bonus: network waterfall sort icon becomes crisp on retina.

BUG=669323
R=dgozman
==========

to

==========
DevTools: convert datagrid and network waterfall sort icons to UI.Icon

This patch converts more icons to UI.Icon:
- the "up/down" sort icons on data grid header cells
- the "up/down" sort icon on the network waterfall

BUG=669323
R=dgozman
==========

[lushnikov, 2017-01-25 00:37:25]

Did a separate patch for the glitch to merge:
https://codereview.chromium.org/2652893008/

[lushnikov, 2017-01-25 00:37:34]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 00:38:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2017-01-25 03:40:49]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2017-01-25 03:40:55]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-01-25 03:40:55]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2649153005/#ps40001
(title: "rebaseline")

[commit-bot: I haz the power, 2017-01-25 03:41:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 04:54:58]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485315655035670,
"parent_rev": "e87f2ba577b96a81dd994ff0cda70ec2c5fef332", "commit_rev":
"f2566bcd386311eb6e0d9e12036b582102687e7d"}

[commit-bot: I haz the power, 2017-01-25 04:55:31]

Description was changed from

==========
DevTools: convert datagrid and network waterfall sort icons to UI.Icon

This patch converts more icons to UI.Icon:
- the "up/down" sort icons on data grid header cells
- the "up/down" sort icon on the network waterfall

BUG=669323
R=dgozman
==========

to

==========
DevTools: convert datagrid and network waterfall sort icons to UI.Icon

This patch converts more icons to UI.Icon:
- the "up/down" sort icons on data grid header cells
- the "up/down" sort icon on the network waterfall

BUG=669323
R=dgozman

Review-Url: https://codereview.chromium.org/2649153005
Cr-Commit-Position: refs/heads/master@{#445952}
Committed:
https://chromium.googlesource.com/chromium/src/+/f2566bcd386311eb6e0d9e12036b...
==========

[commit-bot: I haz the power, 2017-01-25 04:55:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f2566bcd386311eb6e0d9e12036b...