third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js - Issue 2649153005: DevTools: convert datagrid and network waterfall sort icons to UI.Icon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2649153005: DevTools: convert datagrid and network waterfall sort icons to UI.Icon (Closed)

Patch Set: rebaseline Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components/CustomPreviewSection.js ('k') | third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

index 8c62058d640b367a3f0953535898d39f52fb1c71..b800cfbbfeebecf3d4e5c90b1ec415d9b83ec64c 100644

--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

@@ -330,7 +330,7 @@ Console.ConsoleViewMessage = class {

* @param {boolean} expand

function expandStackTrace(expand) {

- icon.setIconType(expand ? 'smallicon-triangle-bottom' : 'smallicon-triangle-right');

+ icon.setIconType(expand ? 'smallicon-triangle-down' : 'smallicon-triangle-right');

stackTraceElement.classList.toggle('hidden', !expand);

}

@@ -1179,7 +1179,7 @@ Console.ConsoleGroupViewMessage = class extends Console.ConsoleViewMessage {

setCollapsed(collapsed) {

this._collapsed = collapsed;

if (this._expandGroupIcon)

- this._expandGroupIcon.setIconType(this._collapsed ? 'smallicon-triangle-right' : 'smallicon-triangle-bottom');

+ this._expandGroupIcon.setIconType(this._collapsed ? 'smallicon-triangle-right' : 'smallicon-triangle-down');

}

/**