Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2649153005: DevTools: convert datagrid and network waterfall sort icons to UI.Icon (Closed)
Patch Set: rebaseline Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
index 37a7b2f2cbfb5768921c0e5765d6b01693e6961c..7d2e6ad138dbc2275b07e4c4fc54b9c3b017ea47 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
@@ -203,8 +203,9 @@ Network.NetworkLogViewColumns = class {
'contextmenu', event => this._innerHeaderContextMenu(new UI.ContextMenu(event)));
var innerElement = this._waterfallHeaderElement.createChild('div');
innerElement.textContent = Common.UIString('Waterfall');
- this._waterfallColumnSortIcon = this._waterfallHeaderElement.createChild('div', 'sort-order-icon-container')
- .createChild('div', 'sort-order-icon');
+ this._waterfallColumnSortIcon = UI.Icon.create('', 'sort-order-icon');
+ this._waterfallHeaderElement.createChild('div', 'sort-order-icon-container')
+ .appendChild(this._waterfallColumnSortIcon);
/**
* @this {Network.NetworkLogViewColumns}
@@ -263,19 +264,18 @@ Network.NetworkLogViewColumns = class {
var columnId = this._dataGrid.sortColumnId();
this._networkLogView.removeAllNodeHighlights();
this._waterfallRequestsAreStale = true;
- this._waterfallColumnSortIcon.classList.remove('sort-ascending', 'sort-descending');
-
if (columnId === 'waterfall') {
if (this._dataGrid.sortOrder() === DataGrid.DataGrid.Order.Ascending)
- this._waterfallColumnSortIcon.classList.add('sort-ascending');
+ this._waterfallColumnSortIcon.setIconType('smallicon-triangle-up');
else
- this._waterfallColumnSortIcon.classList.add('sort-descending');
+ this._waterfallColumnSortIcon.setIconType('smallicon-triangle-down');
var sortFunction = Network.NetworkRequestNode.RequestPropertyComparator.bind(null, this._activeWaterfallSortId);
this._dataGrid.sortNodes(sortFunction, !this._dataGrid.isSortOrderAscending());
this._networkLogView.dataGridSorted();
return;
}
+ this._waterfallColumnSortIcon.setIconType('');
var columnConfig = this._columns.find(columnConfig => columnConfig.id === columnId);
if (!columnConfig || !columnConfig.sortingFunction)

Powered by Google App Engine
This is Rietveld 408576698