Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 2652893008: DevTools: fix network waterfall sorting icon (Closed)

Created:
3 years, 11 months ago by lushnikov
Modified:
3 years, 11 months ago
Reviewers:
dgozman, allada
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix network waterfall sorting icon This patch: - hides network waterfall sorting icon if other column is used for sorting - makes icon crisp on retina BUG=684894 R=dgozman, allada Review-Url: https://codereview.chromium.org/2652893008 Cr-Commit-Position: refs/heads/master@{#445921} Committed: https://chromium.googlesource.com/chromium/src/+/4fad6cb6f585cdfeaccf613a9c310f04260c87c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/networkLogView.css View 1 chunk +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
lushnikov
please, take a look this will be merged to the beta.
3 years, 11 months ago (2017-01-25 00:28:52 UTC) #1
dgozman
lgtm
3 years, 11 months ago (2017-01-25 00:30:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652893008/1
3 years, 11 months ago (2017-01-25 00:35:45 UTC) #4
allada
thanks, lgtm.
3 years, 11 months ago (2017-01-25 00:36:39 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 02:54:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4fad6cb6f585cdfeaccf613a9c31...

Powered by Google App Engine
This is Rietveld 408576698