Remove GetMetadata from PhysicalWebDataSource and PhysicalWebScanner

Remove GetMetadata from PhysicalWebDataSource and PhysicalWebScanner

GetMetadata has been deprecated in favor of GetMetadataList. All previous
uses of GetMetadata have been switched, so let's remove GetMetadata.

BUG=667722
Review-Url: https://codereview.chromium.org/2648973004
Cr-Commit-Position: refs/heads/master@{#445872}
Committed: https://chromium.googlesource.com/chromium/src/+/e35ee04f4a71c990999822ede670b3f4ed51535d

[mattreynolds, 2017-01-23 22:35:05]

mattreynolds@chromium.org changed reviewers:
+ nyquist@chromium.org, sdefresne@chromium.org

[mattreynolds, 2017-01-23 22:35:05]

nyquist@chromium.org: Please review changes in chrome/browser/android

sdefresne@chromium.org: Please review changes in components/physical_web and
ios/chrome

There shouldn't be any behavior changes in this CL, just removing dead code and
tests.

[nyquist, 2017-01-23 22:57:41]

lgtm

[mattreynolds, 2017-01-24 01:25:05]

Description was changed from

==========
Remove GetMetadata from PhysicalWebDataSource and PhysicalWebScanner

GetMetadata has been deprecated in favor of GetMetadataList. All previous
uses of GetMetadata have been switched, so let's remove GetMetadata.

BUG=667722
==========

to

==========
Remove GetMetadata from PhysicalWebDataSource and PhysicalWebScanner

GetMetadata has been deprecated in favor of GetMetadataList. All previous
uses of GetMetadata have been switched, so let's remove GetMetadata.

BUG=667722
==========

[sdefresne, 2017-01-24 09:54:39]

lgtm

https://codereview.chromium.org/2648973004/diff/1/ios/chrome/common/physical_...
File ios/chrome/common/physical_web/physical_web_scanner.h (left):

https://codereview.chromium.org/2648973004/diff/1/ios/chrome/common/physical_...
ios/chrome/common/physical_web/physical_web_scanner.h:62: // will never be nil;
if no metadata has been received then an empty list is
nit: nil -> null (since this is a C++ smart pointer that is returned)

[mattreynolds, 2017-01-24 19:11:44]

Thanks Tommy and Sylvain!

https://codereview.chromium.org/2648973004/diff/1/ios/chrome/common/physical_...
File ios/chrome/common/physical_web/physical_web_scanner.h (left):

https://codereview.chromium.org/2648973004/diff/1/ios/chrome/common/physical_...
ios/chrome/common/physical_web/physical_web_scanner.h:62: // will never be nil;
if no metadata has been received then an empty list is
On 2017/01/24 09:54:38, sdefresne wrote:
> nit: nil -> null (since this is a C++ smart pointer that is returned)

Done.

[mattreynolds, 2017-01-24 22:42:17]

The CQ bit was checked by mattreynolds@chromium.org

[mattreynolds, 2017-01-24 22:42:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
nyquist@chromium.org, sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2648973004/#ps20001
(title: "nil -> null")

[commit-bot: I haz the power, 2017-01-24 22:43:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 23:52:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 23:52:53]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[mattreynolds, 2017-01-24 23:55:49]

The CQ bit was checked by mattreynolds@chromium.org

[commit-bot: I haz the power, 2017-01-24 23:56:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 00:17:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485302149585290,
"parent_rev": "457a88fd89428662bf2c03309b7d266268ebde3a", "commit_rev":
"e35ee04f4a71c990999822ede670b3f4ed51535d"}

[commit-bot: I haz the power, 2017-01-25 00:17:58]

Description was changed from

==========
Remove GetMetadata from PhysicalWebDataSource and PhysicalWebScanner

GetMetadata has been deprecated in favor of GetMetadataList. All previous
uses of GetMetadata have been switched, so let's remove GetMetadata.

BUG=667722
==========

to

==========
Remove GetMetadata from PhysicalWebDataSource and PhysicalWebScanner

GetMetadata has been deprecated in favor of GetMetadataList. All previous
uses of GetMetadata have been switched, so let's remove GetMetadata.

BUG=667722

Review-Url: https://codereview.chromium.org/2648973004
Cr-Commit-Position: refs/heads/master@{#445872}
Committed:
https://chromium.googlesource.com/chromium/src/+/e35ee04f4a71c990999822ede670...
==========

[commit-bot: I haz the power, 2017-01-25 00:18:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e35ee04f4a71c990999822ede670...