Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: components/physical_web/data_source/physical_web_data_source.h

Issue 2648973004: Remove GetMetadata from PhysicalWebDataSource and PhysicalWebScanner (Closed)
Patch Set: nil -> null Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/physical_web/data_source/physical_web_data_source.h
diff --git a/components/physical_web/data_source/physical_web_data_source.h b/components/physical_web/data_source/physical_web_data_source.h
index 0e95c5fe361609e11a31bf8248223ae57dc97af3..1d03230e048ccc061f4dbccc14436f8232f91c74 100644
--- a/components/physical_web/data_source/physical_web_data_source.h
+++ b/components/physical_web/data_source/physical_web_data_source.h
@@ -12,25 +12,10 @@
#include "base/time/time.h"
#include "url/gurl.h"
-namespace base {
-class ListValue;
-}
-
namespace physical_web {
class PhysicalWebListener;
-// Dictionary keys for reading Physical Web URL metadata.
-// TODO(cco3): Remove these when we are no longer dependent.
-extern const char kDescriptionKey[];
-extern const char kDistanceEstimateKey[];
-extern const char kGroupIdKey[];
-extern const char kIconUrlKey[];
-extern const char kResolvedUrlKey[];
-extern const char kScanTimestampKey[];
-extern const char kScannedUrlKey[];
-extern const char kTitleKey[];
-
// Metadata struct for associating data with Physical Web URLs.
struct Metadata {
Metadata();
@@ -96,14 +81,6 @@ class PhysicalWebDataSource {
// list.
virtual std::unique_ptr<MetadataList> GetMetadataList() = 0;
- // Returns a list of resolved URLs and associated page metadata. If network
- // requests are disabled or if discovery is not active, the list will be
- // empty. The method can be called at any time to receive the current metadata
- // list.
- // DEPRECATED
- // TODO(cco3): Remove this when we are no longer dependent on it.
- virtual std::unique_ptr<base::ListValue> GetMetadata() = 0;
-
// Returns boolean |true| if network requests are disabled and there are one
// or more discovered URLs that have not been sent to the resolution service.
// The method can be called at any time to check for unresolved discoveries.

Powered by Google App Engine
This is Rietveld 408576698