Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: chrome/browser/android/physical_web/physical_web_data_source_android.h

Issue 2648973004: Remove GetMetadata from PhysicalWebDataSource and PhysicalWebScanner (Closed)
Patch Set: nil -> null Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/physical_web/physical_web_data_source_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/physical_web/physical_web_data_source_android.h
diff --git a/chrome/browser/android/physical_web/physical_web_data_source_android.h b/chrome/browser/android/physical_web/physical_web_data_source_android.h
index 9e68b58fa9e65b37ea6210602963f75e9510e89e..9b379499aa576a27606521a5ee456cbaed108da7 100644
--- a/chrome/browser/android/physical_web/physical_web_data_source_android.h
+++ b/chrome/browser/android/physical_web/physical_web_data_source_android.h
@@ -11,12 +11,8 @@
#include "base/macros.h"
#include "components/physical_web/data_source/physical_web_data_source_impl.h"
-namespace base {
-class ListValue;
-}
-
// A container for Physical Web metadata. This is primarily a wrapper for a
-// ListValue so we can append to it over JNI.
+// physical_web::MetadataList so we can append to it over JNI.
class PhysicalWebCollection {
public:
PhysicalWebCollection();
@@ -38,14 +34,7 @@ class PhysicalWebCollection {
// caller. Call only once.
std::unique_ptr<physical_web::MetadataList> GetMetadataList();
- // Returns the metadata list and transfers ownership of the list to the
- // caller. Call only once.
- // DEPRECATED
- // TODO(cco3): Remove when we no longer rely on this.
- std::unique_ptr<base::ListValue> GetMetadata();
-
private:
- std::unique_ptr<base::ListValue> dictionary_value_list_;
std::unique_ptr<physical_web::MetadataList> metadata_list_;
bool accessed_once_;
@@ -65,7 +54,6 @@ class PhysicalWebDataSourceAndroid
void StartDiscovery(bool network_request_enabled) override;
void StopDiscovery() override;
- std::unique_ptr<base::ListValue> GetMetadata() override;
std::unique_ptr<physical_web::MetadataList> GetMetadataList() override;
bool HasUnresolvedDiscoveries() override;
« no previous file with comments | « no previous file | chrome/browser/android/physical_web/physical_web_data_source_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698