Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: components/physical_web/data_source/fake_physical_web_data_source.h

Issue 2648973004: Remove GetMetadata from PhysicalWebDataSource and PhysicalWebScanner (Closed)
Patch Set: nil -> null Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/physical_web/data_source/fake_physical_web_data_source.h
diff --git a/components/physical_web/data_source/fake_physical_web_data_source.h b/components/physical_web/data_source/fake_physical_web_data_source.h
index a84e762cfb685cc5cb2141b7120dd362dcc1e20c..fc0a6dc73dc1999dd5df718a0d399606c7ef996f 100644
--- a/components/physical_web/data_source/fake_physical_web_data_source.h
+++ b/components/physical_web/data_source/fake_physical_web_data_source.h
@@ -13,10 +13,6 @@
class GURL;
-namespace base {
-class ListValue;
-}
-
namespace physical_web {
std::unique_ptr<Metadata> CreatePhysicalWebPage(
@@ -42,7 +38,6 @@ class FakePhysicalWebDataSource : public PhysicalWebDataSource {
void StartDiscovery(bool network_request_enabled) override;
void StopDiscovery() override;
- std::unique_ptr<base::ListValue> GetMetadata() override;
std::unique_ptr<MetadataList> GetMetadataList() override;
bool HasUnresolvedDiscoveries() override;
@@ -51,14 +46,12 @@ class FakePhysicalWebDataSource : public PhysicalWebDataSource {
void UnregisterListener(PhysicalWebListener* physical_web_listener) override;
// for testing
- void SetMetadata(std::unique_ptr<base::ListValue> metadata);
void SetMetadataList(std::unique_ptr<MetadataList> metadata_list);
void NotifyOnFound(const GURL& url);
void NotifyOnLost(const GURL& url);
void NotifyOnDistanceChanged(const GURL& url, double distance_estimate);
private:
- std::unique_ptr<base::ListValue> metadata_;
std::unique_ptr<MetadataList> metadata_list_;
base::ObserverList<PhysicalWebListener> observer_list_;

Powered by Google App Engine
This is Rietveld 408576698