[Presentation API] reject request.start() with OperationError instead of UnknownError if previous s…

[Presentation API] reject request.start() with OperationError instead of UnknownError if previous start() is in progress

- add a new presentation error type: PREVIOUS_START_IN_PROGRESS
- PresentationServiceImpl returns PREVIOUS_START_IN_PROGRESS error instead of UNKNOWN error if previous start is in progress
- reject start() promise with OperationError if browser returns PREVIOUS_START_IN_PROGRESS error

BUG=669267
Review-Url: https://codereview.chromium.org/2647723002
Cr-Commit-Position: refs/heads/master@{#445920}
Committed: https://chromium.googlesource.com/chromium/src/+/42c0b54f957c23afbd3fba4058c3fcd4c5ae4041

[zhaobin, 2017-01-19 20:13:11]

zhaobin@chromium.org changed reviewers:
+ dcheng@chromium.org, imcheng@chromium.org, mfoltz@chromium.org

[dcheng, 2017-01-19 22:55:33]

lgtm for mojo and public/platform.

[mark a. foltz, 2017-01-20 18:42:07]

LGTM

It would be a good idea to write a layout test for this, although if there
already an automated Web Platform test that can be upstreamed that is another
option.

[imcheng, 2017-01-20 18:52:00]

lgtm

[zhaobin, 2017-01-20 21:30:18]

Added a layout test for PREVIOUS_START_IN_PROGRESS error.

[zhaobin, 2017-01-20 21:30:46]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 21:31:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 23:02:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 23:02:34]

Dry run: This issue passed the CQ dry run.

[mark a. foltz, 2017-01-23 19:00:03]

Still LGTM

[zhaobin, 2017-01-23 19:05:42]

The CQ bit was checked by zhaobin@chromium.org

[zhaobin, 2017-01-23 19:05:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
imcheng@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2647723002/#ps20001
(title: "add layout test for PREVIOUS_START_IN_PROGRESS error")

[commit-bot: I haz the power, 2017-01-23 19:06:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 19:15:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 19:15:34]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[zhaobin, 2017-01-23 19:47:54]

zhaobin@chromium.org changed reviewers:
+ jam@chromium.org

[zhaobin, 2017-01-23 19:47:55]

+jam@ to review:

content/public/common/presentation_session.h

[jam, 2017-01-24 23:54:46]

lgtm

[zhaobin, 2017-01-25 00:50:09]

The CQ bit was checked by zhaobin@chromium.org

[commit-bot: I haz the power, 2017-01-25 00:50:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 02:50:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485305409522870,
"parent_rev": "647d19eea99f2ca306af65a0805027734a63bd8b", "commit_rev":
"42c0b54f957c23afbd3fba4058c3fcd4c5ae4041"}

[commit-bot: I haz the power, 2017-01-25 02:51:33]

Description was changed from

==========
[Presentation API] reject request.start() with OperationError instead of
UnknownError if previous start() is in progress

- add a new presentation error type: PREVIOUS_START_IN_PROGRESS
- PresentationServiceImpl returns PREVIOUS_START_IN_PROGRESS error instead of
UNKNOWN error if previous start is in progress
- reject start() promise with OperationError if browser returns
PREVIOUS_START_IN_PROGRESS error

BUG=669267
==========

to

==========
[Presentation API] reject request.start() with OperationError instead of
UnknownError if previous start() is in progress

- add a new presentation error type: PREVIOUS_START_IN_PROGRESS
- PresentationServiceImpl returns PREVIOUS_START_IN_PROGRESS error instead of
UNKNOWN error if previous start is in progress
- reject start() promise with OperationError if browser returns
PREVIOUS_START_IN_PROGRESS error

BUG=669267

Review-Url: https://codereview.chromium.org/2647723002
Cr-Commit-Position: refs/heads/master@{#445920}
Committed:
https://chromium.googlesource.com/chromium/src/+/42c0b54f957c23afbd3fba4058c3...
==========

[commit-bot: I haz the power, 2017-01-25 02:51:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/42c0b54f957c23afbd3fba4058c3...