Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: content/browser/presentation/presentation_service_impl.cc

Issue 2647723002: [Presentation API] reject request.start() with OperationError instead of UnknownError if previous s… (Closed)
Patch Set: add layout test for PREVIOUS_START_IN_PROGRESS error Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/presentation/presentation_type_converters.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/presentation/presentation_service_impl.cc
diff --git a/content/browser/presentation/presentation_service_impl.cc b/content/browser/presentation/presentation_service_impl.cc
index 9d870e3adf4c717129a36ad5d51f12538394c494..3da5b3bed61b6b1849513c630222e556609b8204 100644
--- a/content/browser/presentation/presentation_service_impl.cc
+++ b/content/browser/presentation/presentation_service_impl.cc
@@ -109,7 +109,9 @@ void InvokeNewSessionCallbackWithError(
const PresentationServiceImpl::NewSessionCallback& callback) {
callback.Run(blink::mojom::PresentationSessionInfoPtr(),
blink::mojom::PresentationError::From(PresentationError(
- PRESENTATION_ERROR_UNKNOWN, "Internal error")));
+ PRESENTATION_ERROR_PREVIOUS_START_IN_PROGRESS,
+ "There is already an unsettled Promise from a previous call "
+ "to start.")));
}
} // namespace
« no previous file with comments | « no previous file | content/browser/presentation/presentation_type_converters.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698