content/renderer/presentation/presentation_dispatcher.cc - Issue 2647723002: [Presentation API] reject request.start() with OperationError instead of UnknownError if previous s…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/presentation/presentation_dispatcher.cc

Issue 2647723002: [Presentation API] reject request.start() with OperationError instead of UnknownError if previous s… (Closed)

Patch Set: add layout test for PREVIOUS_START_IN_PROGRESS error Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/presentation/presentation_dispatcher.cc

diff --git a/content/renderer/presentation/presentation_dispatcher.cc b/content/renderer/presentation/presentation_dispatcher.cc

index 3d18e10a30a50942721b25bbc21e37315c027ead..8d391d844dee26c86a0c074cd3c732d1b3722eb9 100644

--- a/content/renderer/presentation/presentation_dispatcher.cc

+++ b/content/renderer/presentation/presentation_dispatcher.cc

@@ -54,6 +54,8 @@ blink::WebPresentationError::ErrorType GetWebPresentationErrorTypeFromMojo(

return blink::WebPresentationError::ErrorTypeSessionRequestCancelled;

case blink::mojom::PresentationErrorType::NO_PRESENTATION_FOUND:

return blink::WebPresentationError::ErrorTypeNoPresentationFound;

+ case blink::mojom::PresentationErrorType::PREVIOUS_START_IN_PROGRESS:

+ return blink::WebPresentationError::ErrorTypePreviousStartInProgress;

case blink::mojom::PresentationErrorType::UNKNOWN:

default:

return blink::WebPresentationError::ErrorTypeUnknown;