third_party/WebKit/Source/modules/presentation/PresentationError.cpp - Issue 2647723002: [Presentation API] reject request.start() with OperationError instead of UnknownError if previous s…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationError.cpp

Issue 2647723002: [Presentation API] reject request.start() with OperationError instead of UnknownError if previous s… (Closed)

Patch Set: add layout test for PREVIOUS_START_IN_PROGRESS error Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/presentation/presentation-start-error.html ('k') | third_party/WebKit/public/platform/modules/presentation/WebPresentationError.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationError.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationError.cpp b/third_party/WebKit/Source/modules/presentation/PresentationError.cpp

index f238e043fc4c53f71c11317c0d5415f81d2fec48..3b1aca0e6bfd325c1560e0f28b4365a11a696f67 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationError.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationError.cpp

@@ -24,6 +24,9 @@ DOMException* PresentationError::take(const WebPresentationError& error) {

case WebPresentationError::ErrorTypeAvailabilityNotSupported:

code = NotSupportedError;

break;

+ case WebPresentationError::ErrorTypePreviousStartInProgress:

+ code = OperationError;

+ break;

case WebPresentationError::ErrorTypeUnknown:

code = UnknownError;

break;