[DevTools] Improve context and target naming.

[DevTools] Improve context and target naming.

- nested iframes now get proper indentation in console;
- each target's top frame is now a parent to other frames in navigator;
- only main target's top frame is displayed as 'top'.

BUG=678435
Review-Url: https://codereview.chromium.org/2647153002
Cr-Commit-Position: refs/heads/master@{#445615}
Committed: https://chromium.googlesource.com/chromium/src/+/92ec9c389c41ecc50190973a3375e0d47d839ade

[dgozman, 2017-01-21 01:38:38]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2017-01-21 01:38:38]

Could you please take a look?

[pfeldman, 2017-01-21 02:21:24]

https://codereview.chromium.org/2647153002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js
(right):

https://codereview.chromium.org/2647153002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js:36:
var target = executionContext.target();
According to the new guidelines, you should use const here.

[pfeldman, 2017-01-21 02:22:50]

https://codereview.chromium.org/2647153002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js
(right):

https://codereview.chromium.org/2647153002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js:36:
var target = executionContext.target();
On 2017/01/21 02:21:24, pfeldman wrote:
> According to the new guidelines, you should use const here.

My bad, it should be let.

[pfeldman, 2017-01-21 02:27:31]

lgtm

https://codereview.chromium.org/2647153002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js
(right):

https://codereview.chromium.org/2647153002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js:54:
if (target.parentTarget().hasJSCapability())
Special case service workers?

[dgozman, 2017-01-23 19:20:35]

https://codereview.chromium.org/2647153002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js
(right):

https://codereview.chromium.org/2647153002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js:54:
if (target.parentTarget().hasJSCapability())
On 2017/01/21 02:27:31, pfeldman wrote:
> Special case service workers?

Done.

[dgozman, 2017-01-23 20:03:24]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-01-23 20:03:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2647153002/#ps20001
(title: "fixed comments and sorting")

[commit-bot: I haz the power, 2017-01-23 20:04:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 20:15:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 20:15:09]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[dgozman, 2017-01-23 23:24:07]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2017-01-23 23:24:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 02:40:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485213847432310,
"parent_rev": "92ca74c980364bd8f0eae8186cf2a546ffc27678", "commit_rev":
"92ec9c389c41ecc50190973a3375e0d47d839ade"}

[commit-bot: I haz the power, 2017-01-24 02:41:08]

Description was changed from

==========
[DevTools] Improve context and target naming.

- nested iframes now get proper indentation in console;
- each target's top frame is now a parent to other frames in navigator;
- only main target's top frame is displayed as 'top'.

BUG=678435
==========

to

==========
[DevTools] Improve context and target naming.

- nested iframes now get proper indentation in console;
- each target's top frame is now a parent to other frames in navigator;
- only main target's top frame is displayed as 'top'.

BUG=678435

Review-Url: https://codereview.chromium.org/2647153002
Cr-Commit-Position: refs/heads/master@{#445615}
Committed:
https://chromium.googlesource.com/chromium/src/+/92ec9c389c41ecc50190973a3375...
==========

[commit-bot: I haz the power, 2017-01-24 02:41:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/92ec9c389c41ecc50190973a3375...