Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

Issue 2647153002: [DevTools] Improve context and target naming. (Closed)
Patch Set: fixed comments and sorting Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js b/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
index e9f0577bb54612366999201fb5b1f9f30cfb855c..b6babd0cf369bfb6a033c39a655953a1d1e1710f 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
@@ -424,6 +424,9 @@ Sources.NavigatorView = class extends UI.VBox {
if (!this._groupByFrame || !frame)
return this._targetNode(project, target);
+ if (!frame.parentFrame && target.parentTarget())
+ return this._targetNode(project, target);
+
var frameNode = this._frameNodes.get(frame);
if (frameNode)
return frameNode;
@@ -464,8 +467,7 @@ Sources.NavigatorView = class extends UI.VBox {
if (!targetNode) {
targetNode = new Sources.NavigatorGroupTreeNode(
this, project, 'target:' + target.id(),
- !target.hasBrowserCapability() ? Sources.NavigatorView.Types.Worker :
- Sources.NavigatorView.Types.NetworkFolder,
+ !target.hasBrowserCapability() ? Sources.NavigatorView.Types.Worker : Sources.NavigatorView.Types.Frame,
target.name());
this._rootNode.appendChild(targetNode);
}
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698