third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html - Issue 2647153002: [DevTools] Improve context and target naming.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html

Issue 2647153002: [DevTools] Improve context and target naming. (Closed)

Patch Set: fixed comments and sorting Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-sorting-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html

index 4bdd64db49dd16220a19ffb63d2c00d13c6ee308..46fc60e082ab3c19acff587388fc1aac8a84ef2a 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html

@@ -26,9 +26,9 @@ function test()

InspectorTest.addResult("");

InspectorTest.addResult("Adding page target");

- var pageTarget = InspectorTest.createMockTarget("page-target");

- SDK.ResourceTreeModel.fromTarget(pageTarget)._cachedResourcesProcessed = true;

- SDK.ResourceTreeModel.fromTarget(pageTarget)._frameAttached("42", 0);

+ var pageTarget = InspectorTest.createMockTarget("page-target", SDK.Target.Capability.AllForTests, true /* dontAttachToMain */);

+ SDK.ResourceTreeModel.fromTarget(pageTarget)._frameAttached('42', '');

+ SDK.ResourceTreeModel.fromTarget(pageTarget)._frameNavigated({id: '42', parentId: '', loaderId: '', name: 'mock-frame', url: 'mock-url.com/frame.html', securityOrigin: 'mock-security-origin', mineType: 'mimeType'});

pageTarget.runtimeModel._executionContextCreated({id: "cs1", auxData: { isDefault: false, frameId: "42" }, origin: "origin", name: "contentScript1"});

pageTarget.runtimeModel._executionContextCreated({id: "if1", auxData: { isDefault: true, frameId: "iframe1" }, origin: "origin", name: "iframeContext1"});

pageTarget.runtimeModel._executionContextCreated({id: "p1", auxData: { isDefault: true, frameId: "42" }, origin: "origin", name: "pageContext1Name"});