third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html - Issue 2647153002: [DevTools] Improve context and target naming.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html

Issue 2647153002: [DevTools] Improve context and target naming. (Closed)

Patch Set: fixed comments and sorting Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-sorting-expected.txt ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html

index 51ca9450b3131e97d096b354bdc301753c509ebc..3d37ee39dc5cc8fdef229c6cf2cfa90745c95d19 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html

@@ -8,9 +8,10 @@ function test()

{

var networkProject1 = Bindings.NetworkProject.forTarget(InspectorTest.mainTarget);

networkProject1._reset();

- var target2 = InspectorTest.createMockTarget("mock-target-100");

+ var target2 = InspectorTest.createMockTarget('mock-target-100');

SDK.ResourceTreeModel.fromTarget(target2)._cachedResourcesProcessed = true;

- SDK.ResourceTreeModel.fromTarget(target2)._frameAttached("42", 0);

+ SDK.ResourceTreeModel.fromTarget(target2)._frameAttached('42', '');

+ SDK.ResourceTreeModel.fromTarget(target2)._frameNavigated({id: '42', parentId: '', loaderId: '', name: 'mock-frame', url: 'mock-url.com/frame.html', securityOrigin: 'mock-security-origin', mineType: 'mimeType'});

var networkProject2 = Bindings.NetworkProject.forTarget(target2);

var subframe = InspectorTest.mainFrame().childFrames[0];