Remove STACK_ALLOCATED() from ScopedTestingPlatformSupport

Remove STACK_ALLOCATED() from ScopedTestingPlatformSupport

Since I have seen some use cases where it's beneficial to have
ScopedTestingPlatformSupport as a member variable, let's make
ScopedTestingPlatformSupport available as a member variable.

It's usual that tests need to initialize something after the
mocked platform is registered. If we could have the
ScopedTestingPlatformSupport as a member, we can have such
initialization code in testing::Test::SetUp(). This can remove
many boilerplate code from each test definition.

Also, some tests need to have a helper methods that access to
the ScopedTestingPlatformSupport. In such case, having it as
a member makes code much simple.

BUG=655920
TEST=webkit_unit_tests
TBR=hongchan@chromium.org

Review-Url: https://codereview.chromium.org/2645733003
Cr-Commit-Position: refs/heads/master@{#444683}
Committed: https://chromium.googlesource.com/chromium/src/+/e13f57fbda95f7260cdfb7c7610fcdeeb36e1991

[Takashi Toyoshima, 2017-01-19 05:26:49]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 05:27:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2017-01-19 05:27:49]

Description was changed from

==========
Remove STACK_ALLOCATED() from ScopedTestingPlatformSupport

Since I have seen some use cases where it's beneficial to have
ScopedTestingPlatformSupport as a member variable, let's make
ScopedTestingPlatformSupport available as a member variable.

It's usual that tests need to initialize something after the
mocked platform is registered. If we could have the
ScopedTestingPlatformSupport as a member, we can have such
initialization code in testing::Test::SetUp(). This can remove
many boilerplate code from each test definition.

Also, some tests need to have a helper methods that access to
the ScopedTestingPlatformSupport. In such case, having it as
a member makes code much simple.

BUG=655920
TEST=webkit_unit_tests
==========

to

==========
Remove STACK_ALLOCATED() from ScopedTestingPlatformSupport

Since I have seen some use cases where it's beneficial to have
ScopedTestingPlatformSupport as a member variable, let's make
ScopedTestingPlatformSupport available as a member variable.

It's usual that tests need to initialize something after the
mocked platform is registered. If we could have the
ScopedTestingPlatformSupport as a member, we can have such
initialization code in testing::Test::SetUp(). This can remove
many boilerplate code from each test definition.

Also, some tests need to have a helper methods that access to
the ScopedTestingPlatformSupport. In such case, having it as
a member makes code much simple.

BUG=655920
TEST=webkit_unit_tests
TBR=hongchan@chromium.org
==========

[Takashi Toyoshima, 2017-01-19 05:27:49]

toyoshim@chromium.org changed reviewers:
+ kinuko@chromium.org

[Takashi Toyoshima, 2017-01-19 05:28:54]

Kinuko, can you take a look?

[kinuko, 2017-01-19 05:30:40]

lgtm

[haraken, 2017-01-19 06:37:16]

LGTM, nice.

[commit-bot: I haz the power, 2017-01-19 06:45:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 06:45:09]

Dry run: This issue passed the CQ dry run.

[Takashi Toyoshima, 2017-01-19 08:28:35]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2017-01-19 08:29:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 08:33:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484814515066000, "parent_rev":
"03d984c79b0943e27f6b1239689a15b4830f4fd3", "commit_rev":
"e13f57fbda95f7260cdfb7c7610fcdeeb36e1991"}

[commit-bot: I haz the power, 2017-01-19 08:33:53]

Description was changed from

==========
Remove STACK_ALLOCATED() from ScopedTestingPlatformSupport

Since I have seen some use cases where it's beneficial to have
ScopedTestingPlatformSupport as a member variable, let's make
ScopedTestingPlatformSupport available as a member variable.

It's usual that tests need to initialize something after the
mocked platform is registered. If we could have the
ScopedTestingPlatformSupport as a member, we can have such
initialization code in testing::Test::SetUp(). This can remove
many boilerplate code from each test definition.

Also, some tests need to have a helper methods that access to
the ScopedTestingPlatformSupport. In such case, having it as
a member makes code much simple.

BUG=655920
TEST=webkit_unit_tests
TBR=hongchan@chromium.org
==========

to

==========
Remove STACK_ALLOCATED() from ScopedTestingPlatformSupport

Since I have seen some use cases where it's beneficial to have
ScopedTestingPlatformSupport as a member variable, let's make
ScopedTestingPlatformSupport available as a member variable.

It's usual that tests need to initialize something after the
mocked platform is registered. If we could have the
ScopedTestingPlatformSupport as a member, we can have such
initialization code in testing::Test::SetUp(). This can remove
many boilerplate code from each test definition.

Also, some tests need to have a helper methods that access to
the ScopedTestingPlatformSupport. In such case, having it as
a member makes code much simple.

BUG=655920
TEST=webkit_unit_tests
TBR=hongchan@chromium.org

Review-Url: https://codereview.chromium.org/2645733003
Cr-Commit-Position: refs/heads/master@{#444683}
Committed:
https://chromium.googlesource.com/chromium/src/+/e13f57fbda95f7260cdfb7c7610f...
==========

[commit-bot: I haz the power, 2017-01-19 08:33:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e13f57fbda95f7260cdfb7c7610f...