Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Unified Diff: third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp

Issue 2645733003: Remove STACK_ALLOCATED() from ScopedTestingPlatformSupport (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp
diff --git a/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp b/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp
index f815691f431acf35d46a75c9dc9f9fe3fae8fedf..9f946e4ad6b6673c54d8acd2e18cd0a7a339f258 100644
--- a/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp
+++ b/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp
@@ -128,6 +128,7 @@ class AnimationWorkletThreadTest : public ::testing::Test {
RefPtr<SecurityOrigin> m_securityOrigin;
std::unique_ptr<WorkerReportingProxy> m_reportingProxy;
+ ScopedTestingPlatformSupport<AnimationWorkletTestPlatform> m_platform;
};
TEST_F(AnimationWorkletThreadTest, Basic) {
@@ -142,8 +143,6 @@ TEST_F(AnimationWorkletThreadTest, Basic) {
// Tests that the same WebThread is used for new worklets if the WebThread is
// still alive.
TEST_F(AnimationWorkletThreadTest, CreateSecondAndTerminateFirst) {
- ScopedTestingPlatformSupport<AnimationWorkletTestPlatform> platform;
-
// Create the first worklet and wait until it is initialized.
std::unique_ptr<AnimationWorkletThread> firstWorklet =
createAnimationWorkletThread();
@@ -179,8 +178,6 @@ TEST_F(AnimationWorkletThreadTest, CreateSecondAndTerminateFirst) {
// Tests that a new WebThread is created if all existing worklets are
// terminated before a new worklet is created.
TEST_F(AnimationWorkletThreadTest, TerminateFirstAndCreateSecond) {
- ScopedTestingPlatformSupport<AnimationWorkletTestPlatform> platform;
-
// Create the first worklet, wait until it is initialized, and terminate it.
std::unique_ptr<AnimationWorkletThread> worklet =
createAnimationWorkletThread();
@@ -205,8 +202,6 @@ TEST_F(AnimationWorkletThreadTest, TerminateFirstAndCreateSecond) {
// Tests that v8::Isolate and WebThread are correctly set-up if a worklet is
// created while another is terminating.
TEST_F(AnimationWorkletThreadTest, CreatingSecondDuringTerminationOfFirst) {
- ScopedTestingPlatformSupport<AnimationWorkletTestPlatform> platform;
-
std::unique_ptr<AnimationWorkletThread> firstWorklet =
createAnimationWorkletThread();
checkWorkletCanExecuteScript(firstWorklet.get());

Powered by Google App Engine
This is Rietveld 408576698