Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Unified Diff: third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp

Issue 2645733003: Remove STACK_ALLOCATED() from ScopedTestingPlatformSupport (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp b/third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp
index 835600d6355e0b51ee62442d702dc0909fce92b5..1eecc8a7ebebaf2beb07897a427e283e83a75223 100644
--- a/third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp
@@ -121,12 +121,11 @@ class BaseAudioContextTest : public ::testing::Test {
private:
std::unique_ptr<DummyPageHolder> m_dummyPageHolder;
Persistent<DummyFrameOwner> m_dummyFrameOwner;
-
Persistent<LocalFrame> m_childFrame;
+ ScopedTestingPlatformSupport<BaseAudioContextTestPlatform> m_platform;
};
TEST_F(BaseAudioContextTest, AutoplayMetrics_NoRestriction) {
- ScopedTestingPlatformSupport<BaseAudioContextTestPlatform> platform;
HistogramTester histogramTester;
BaseAudioContext* audioContext =
@@ -137,7 +136,6 @@ TEST_F(BaseAudioContextTest, AutoplayMetrics_NoRestriction) {
}
TEST_F(BaseAudioContextTest, AutoplayMetrics_CreateNoGesture) {
- ScopedTestingPlatformSupport<BaseAudioContextTestPlatform> platform;
HistogramTester histogramTester;
createChildFrame();
childDocument().settings()->setMediaPlaybackRequiresUserGesture(true);
@@ -152,7 +150,6 @@ TEST_F(BaseAudioContextTest, AutoplayMetrics_CreateNoGesture) {
}
TEST_F(BaseAudioContextTest, AutoplayMetrics_CallResumeNoGesture) {
- ScopedTestingPlatformSupport<BaseAudioContextTestPlatform> platform;
HistogramTester histogramTester;
createChildFrame();
childDocument().settings()->setMediaPlaybackRequiresUserGesture(true);
@@ -171,7 +168,6 @@ TEST_F(BaseAudioContextTest, AutoplayMetrics_CallResumeNoGesture) {
}
TEST_F(BaseAudioContextTest, AutoplayMetrics_CreateGesture) {
- ScopedTestingPlatformSupport<BaseAudioContextTestPlatform> platform;
HistogramTester histogramTester;
createChildFrame();
childDocument().settings()->setMediaPlaybackRequiresUserGesture(true);
@@ -189,7 +185,6 @@ TEST_F(BaseAudioContextTest, AutoplayMetrics_CreateGesture) {
}
TEST_F(BaseAudioContextTest, AutoplayMetrics_CallResumeGesture) {
- ScopedTestingPlatformSupport<BaseAudioContextTestPlatform> platform;
HistogramTester histogramTester;
createChildFrame();
childDocument().settings()->setMediaPlaybackRequiresUserGesture(true);
@@ -212,7 +207,6 @@ TEST_F(BaseAudioContextTest, AutoplayMetrics_CallResumeGesture) {
}
TEST_F(BaseAudioContextTest, AutoplayMetrics_NodeStartNoGesture) {
- ScopedTestingPlatformSupport<BaseAudioContextTestPlatform> platform;
HistogramTester histogramTester;
createChildFrame();
childDocument().settings()->setMediaPlaybackRequiresUserGesture(true);
@@ -228,7 +222,6 @@ TEST_F(BaseAudioContextTest, AutoplayMetrics_NodeStartNoGesture) {
}
TEST_F(BaseAudioContextTest, AutoplayMetrics_NodeStartGesture) {
- ScopedTestingPlatformSupport<BaseAudioContextTestPlatform> platform;
HistogramTester histogramTester;
createChildFrame();
childDocument().settings()->setMediaPlaybackRequiresUserGesture(true);
@@ -247,7 +240,6 @@ TEST_F(BaseAudioContextTest, AutoplayMetrics_NodeStartGesture) {
}
TEST_F(BaseAudioContextTest, AutoplayMetrics_NodeStartNoGestureThenSuccess) {
- ScopedTestingPlatformSupport<BaseAudioContextTestPlatform> platform;
HistogramTester histogramTester;
createChildFrame();
childDocument().settings()->setMediaPlaybackRequiresUserGesture(true);
@@ -270,7 +262,6 @@ TEST_F(BaseAudioContextTest, AutoplayMetrics_NodeStartNoGestureThenSuccess) {
}
TEST_F(BaseAudioContextTest, AutoplayMetrics_NodeStartGestureThenSucces) {
- ScopedTestingPlatformSupport<BaseAudioContextTestPlatform> platform;
HistogramTester histogramTester;
createChildFrame();
childDocument().settings()->setMediaPlaybackRequiresUserGesture(true);

Powered by Google App Engine
This is Rietveld 408576698