Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Unified Diff: third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp

Issue 2645733003: Remove STACK_ALLOCATED() from ScopedTestingPlatformSupport (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
diff --git a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp b/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
index 848149430886f5df36b8adfa55e9b1f94daf862c..c58f4a80d5189eaab330e40be7864922ee0bb6bf 100644
--- a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
+++ b/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
@@ -143,11 +143,10 @@ class CompositorWorkerThreadTest : public ::testing::Test {
RefPtr<SecurityOrigin> m_securityOrigin;
std::unique_ptr<InProcessWorkerObjectProxy> m_objectProxy;
+ ScopedTestingPlatformSupport<CompositorWorkerTestPlatform> m_platform;
};
TEST_F(CompositorWorkerThreadTest, Basic) {
- ScopedTestingPlatformSupport<CompositorWorkerTestPlatform> platform;
-
std::unique_ptr<CompositorWorkerThread> compositorWorker =
createCompositorWorker();
checkWorkerCanExecuteScript(compositorWorker.get());
@@ -157,8 +156,6 @@ TEST_F(CompositorWorkerThreadTest, Basic) {
// Tests that the same WebThread is used for new workers if the WebThread is
// still alive.
TEST_F(CompositorWorkerThreadTest, CreateSecondAndTerminateFirst) {
- ScopedTestingPlatformSupport<CompositorWorkerTestPlatform> platform;
-
// Create the first worker and wait until it is initialized.
std::unique_ptr<CompositorWorkerThread> firstWorker =
createCompositorWorker();
@@ -194,8 +191,6 @@ TEST_F(CompositorWorkerThreadTest, CreateSecondAndTerminateFirst) {
// Tests that a new WebThread is created if all existing workers are terminated
// before a new worker is created.
TEST_F(CompositorWorkerThreadTest, TerminateFirstAndCreateSecond) {
- ScopedTestingPlatformSupport<CompositorWorkerTestPlatform> platform;
-
// Create the first worker, wait until it is initialized, and terminate it.
std::unique_ptr<CompositorWorkerThread> compositorWorker =
createCompositorWorker();
@@ -220,8 +215,6 @@ TEST_F(CompositorWorkerThreadTest, TerminateFirstAndCreateSecond) {
// Tests that v8::Isolate and WebThread are correctly set-up if a worker is
// created while another is terminating.
TEST_F(CompositorWorkerThreadTest, CreatingSecondDuringTerminationOfFirst) {
- ScopedTestingPlatformSupport<CompositorWorkerTestPlatform> platform;
-
std::unique_ptr<CompositorWorkerThread> firstWorker =
createCompositorWorker();
checkWorkerCanExecuteScript(firstWorker.get());

Powered by Google App Engine
This is Rietveld 408576698