Chromium Code Reviews
Help | Chromium Project | Sign in
(41)

Issue 2645093003: [WIP] ScreenManager: Add an external window mode (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by fwang
Modified:
2 months, 1 week ago
CC:
chromium-reviews, tonikitoo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ScreenManager: Add an external window mode An "external window mode" parameter is added to the ScreenManager init in order to prepare [1]. In that mode, no initial displays are created or initialized. This mode is used by the WindowServer when the window manager is not connected to any WindowTree. Based on the original work of Thomas Anderson in [2]. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=666958 [2] https://codereview.chromium.org/2503923003/ BUG=666958

Patch Set 1 #

Total comments: 11
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -31 lines) Patch
M services/ui/display/screen_manager.h View 2 chunks +13 lines, -6 lines 4 comments Download
M services/ui/display/screen_manager_ozone.h View 1 chunk +1 line, -1 line 1 comment Download
M services/ui/display/screen_manager_ozone.cc View 2 chunks +10 lines, -7 lines 0 comments Download
M services/ui/display/screen_manager_ozone_unittests.cc View 1 chunk +1 line, -1 line 2 comments Download
M services/ui/display/screen_manager_stub.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/display/screen_manager_stub.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/ui/service.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/service.cc View 1 chunk +5 lines, -2 lines 2 comments Download
M services/ui/ws/cursor_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/ui/ws/display_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/ui/ws/test_utils.h View 2 chunks +3 lines, -2 lines 0 comments Download
M services/ui/ws/test_utils.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M services/ui/ws/user_display_manager_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/ui/ws/window_manager_state_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/ui/ws/window_server.cc View 1 chunk +8 lines, -1 line 2 comments Download
M services/ui/ws/window_server_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/window_tree_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 21 (9 generated)
fwang
PTAL I'm extracting this part from https://codereview.chromium.org/2622103004/ in order to simplify review. It is essentially ...
3 months ago (2017-01-21 14:47:57 UTC) #4
sky
+kylechar
3 months ago (2017-01-23 16:16:20 UTC) #9
rjkroege
https://codereview.chromium.org/2645093003/diff/1/services/ui/display/screen_manager.h File services/ui/display/screen_manager.h (right): https://codereview.chromium.org/2645093003/diff/1/services/ui/display/screen_manager.h#newcode24 services/ui/display/screen_manager.h:24: WINDOW_MODE_EXTERNAL, We've emailed enough to know what these mean ...
3 months ago (2017-01-23 21:19:44 UTC) #11
fwang
https://codereview.chromium.org/2645093003/diff/1/services/ui/display/screen_manager.h File services/ui/display/screen_manager.h (right): https://codereview.chromium.org/2645093003/diff/1/services/ui/display/screen_manager.h#newcode24 services/ui/display/screen_manager.h:24: WINDOW_MODE_EXTERNAL, On 2017/01/23 21:19:43, rjkroege wrote: > We've emailed ...
3 months ago (2017-01-24 17:11:51 UTC) #13
rjkroege
On 2017/01/24 17:11:51, fwang wrote: > https://codereview.chromium.org/2645093003/diff/1/services/ui/display/screen_manager.h > File services/ui/display/screen_manager.h (right): > > https://codereview.chromium.org/2645093003/diff/1/services/ui/display/screen_manager.h#newcode24 > ...
3 months ago (2017-01-24 19:29:31 UTC) #14
kylechar
https://codereview.chromium.org/2645093003/diff/1/services/ui/display/screen_manager_ozone.h File services/ui/display/screen_manager_ozone.h (right): https://codereview.chromium.org/2645093003/diff/1/services/ui/display/screen_manager_ozone.h#newcode52 services/ui/display/screen_manager_ozone.h:52: void RequestCloseDisplay(int64_t display_id) override; I don't think this is ...
3 months ago (2017-01-25 13:04:48 UTC) #15
kylechar
What platform are you trying to target for external window mode first? Is it something ...
3 months ago (2017-01-25 13:08:49 UTC) #16
rjkroege
On 2017/01/25 13:08:49, kylechar wrote: > What platform are you trying to target for external ...
3 months ago (2017-01-25 19:33:47 UTC) #17
fwang
On 2017/01/25 13:04:48, kylechar wrote: > https://codereview.chromium.org/2645093003/diff/1/services/ui/display/screen_manager_ozone.h > File services/ui/display/screen_manager_ozone.h (right): > > https://codereview.chromium.org/2645093003/diff/1/services/ui/display/screen_manager_ozone.h#newcode52 > ...
2 months, 2 weeks ago (2017-02-07 16:41:04 UTC) #18
fwang
On 2017/01/25 19:33:47, rjkroege wrote: > On 2017/01/25 13:08:49, kylechar wrote: > > What platform ...
2 months, 2 weeks ago (2017-02-07 16:42:58 UTC) #19
fwang
2 months, 2 weeks ago (2017-02-08 13:25:19 UTC) #20
fwang
2 months, 1 week ago (2017-02-16 08:33:44 UTC) #21
This commit is obsolete since we decided to not support external mode in
ChromeOS. Antonio implemented a screen manager without display init for
non-ChromeOS ozone in https://codereview.chromium.org/2697693002/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46