Stub out ScreenManagerOzoneExternal

Stub out ScreenManagerOzoneExternal

This is a step forward in order to have mus_demo
(//services/ui/demo/) running in "external window mode".

In external window mode, the need for a ScreenManager and
ScreenManagerDelegate (aka DisplayManager) is eased.
CL adds an stub'ed out implementation to be used on ozone/non-chromeos.

BUG=666958
Review-Url: https://codereview.chromium.org/2697693002
Cr-Commit-Position: refs/heads/master@{#450155}
Committed: https://chromium.googlesource.com/chromium/src/+/5a9fe272cb758a4a60f251bd797144fa7c75e79f

[tonikitoo, 2017-02-13 21:03:23]

The CQ bit was checked by tonikitoo@igalia.com to run a CQ dry run

[tonikitoo, 2017-02-13 21:03:47]

Description was changed from

==========
Stub out ScreenManagerOzoneExternal

This is a step forward in order to have mus_demo
(//services/ui/demo/) running in "external window mode".

In external window mode, the need for a ScreenManager and
ScreenManagerDelegate (aka DisplayManager) is eased.
CL adds an stub'ed out implementation to be used on ozone/non-chromeos.

BUG=666958
==========

to

==========
Stub out ScreenManagerOzoneExternal

This is a step forward in order to have mus_demo
(//services/ui/demo/) running in "external window mode".

In external window mode, the need for a ScreenManager and
ScreenManagerDelegate (aka DisplayManager) is eased.
CL adds an stub'ed out implementation to be used on ozone/non-chromeos.

BUG=666958
==========

[tonikitoo, 2017-02-13 21:03:47]

tonikitoo@igalia.com changed reviewers:
+ kylechar@chromium.org

[commit-bot: I haz the power, 2017-02-13 21:04:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylechar, 2017-02-13 21:23:38]

https://codereview.chromium.org/2697693002/diff/20001/services/ui/display/BUI...
File services/ui/display/BUILD.gn (left):

https://codereview.chromium.org/2697693002/diff/20001/services/ui/display/BUI...
services/ui/display/BUILD.gn:39: "screen_manager_stub_internal.cc",
We still need screen_manager_stub_internal.cc/h if use_ozone=false. Some tests
run on Linux/Windows and will go through the internal mode code path.

[tonikitoo, 2017-02-13 21:37:38]

https://codereview.chromium.org/2697693002/diff/20001/services/ui/display/BUI...
File services/ui/display/BUILD.gn (left):

https://codereview.chromium.org/2697693002/diff/20001/services/ui/display/BUI...
services/ui/display/BUILD.gn:39: "screen_manager_stub_internal.cc",
On 2017/02/13 21:23:38, kylechar wrote:
> We still need screen_manager_stub_internal.cc/h if use_ozone=false. Some tests
> run on Linux/Windows and will go through the internal mode code path.

Done.

[tonikitoo, 2017-02-13 21:37:56]

The CQ bit was checked by tonikitoo@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 21:38:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylechar, 2017-02-13 21:45:59]

lgtm other than the one comment.

https://codereview.chromium.org/2697693002/diff/40001/services/ui/display/scr...
File services/ui/display/screen_manager_ozone_external.h (right):

https://codereview.chromium.org/2697693002/diff/40001/services/ui/display/scr...
services/ui/display/screen_manager_ozone_external.h:32:
base::WeakPtrFactory<ScreenManagerOzoneExternal> weak_ptr_factory_;
I don't think you need the WeakPtrFactory? It's not used.

[tonikitoo, 2017-02-13 21:55:43]

The CQ bit was checked by tonikitoo@igalia.com

[tonikitoo, 2017-02-13 21:55:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
kylechar@chromium.org
Link to the patchset: https://codereview.chromium.org/2697693002/#ps60001
(title: "removed bits of WeakPtrFactory use")

[commit-bot: I haz the power, 2017-02-13 21:56:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fwang, 2017-02-13 21:58:37]

fwang@igalia.com changed reviewers:
+ fwang@igalia.com

[fwang, 2017-02-13 21:58:38]

informal l g t m  modulo a typo (hope it's not too late)

https://codereview.chromium.org/2697693002/diff/60001/services/ui/display/scr...
File services/ui/display/screen_manager_ozone_external.h (right):

https://codereview.chromium.org/2697693002/diff/60001/services/ui/display/scr...
services/ui/display/screen_manager_ozone_external.h:14: // responsible for
creating Dislpay instances.
Display

[tonikitoo, 2017-02-13 22:09:18]

The CQ bit was checked by tonikitoo@igalia.com

[tonikitoo, 2017-02-13 22:09:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
kylechar@chromium.org
Link to the patchset: https://codereview.chromium.org/2697693002/#ps100001
(title: "fixed typo")

[tonikitoo, 2017-02-13 22:09:43]

https://codereview.chromium.org/2697693002/diff/60001/services/ui/display/scr...
File services/ui/display/screen_manager_ozone_external.h (right):

https://codereview.chromium.org/2697693002/diff/60001/services/ui/display/scr...
services/ui/display/screen_manager_ozone_external.h:14: // responsible for
creating Dislpay instances.
On 2017/02/13 21:58:37, fwang wrote:
> Display

Done.

[commit-bot: I haz the power, 2017-02-13 22:10:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 23:50:55]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1487023758384660,
"parent_rev": "b1df829bf7a49fc52274b2651d4688a5454718ef", "commit_rev":
"5a9fe272cb758a4a60f251bd797144fa7c75e79f"}

[commit-bot: I haz the power, 2017-02-13 23:51:40]

Description was changed from

==========
Stub out ScreenManagerOzoneExternal

This is a step forward in order to have mus_demo
(//services/ui/demo/) running in "external window mode".

In external window mode, the need for a ScreenManager and
ScreenManagerDelegate (aka DisplayManager) is eased.
CL adds an stub'ed out implementation to be used on ozone/non-chromeos.

BUG=666958
==========

to

==========
Stub out ScreenManagerOzoneExternal

This is a step forward in order to have mus_demo
(//services/ui/demo/) running in "external window mode".

In external window mode, the need for a ScreenManager and
ScreenManagerDelegate (aka DisplayManager) is eased.
CL adds an stub'ed out implementation to be used on ozone/non-chromeos.

BUG=666958

Review-Url: https://codereview.chromium.org/2697693002
Cr-Commit-Position: refs/heads/master@{#450155}
Committed:
https://chromium.googlesource.com/chromium/src/+/5a9fe272cb758a4a60f251bd7971...
==========

[commit-bot: I haz the power, 2017-02-13 23:51:44]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/5a9fe272cb758a4a60f251bd7971...