[WIP] ScreenManager: Add an external window mode

services/ui/display/screen_manager_ozone_unittests.cc

Index: services/ui/display/screen_manager_ozone_unittests.cc
diff --git a/services/ui/display/screen_manager_ozone_unittests.cc b/services/ui/display/screen_manager_ozone_unittests.cc
index 16307a01eec2b167387a63ab761a2adb5eac07e4..d74445d604344730d12ad43641dc6e4d8efdb87b 100644
--- a/services/ui/display/screen_manager_ozone_unittests.cc
+++ b/services/ui/display/screen_manager_ozone_unittests.cc
@@ -168,7 +168,7 @@ class ScreenManagerOzoneTest : public ui::TaskRunnerTestBase {
                    .SetType(DISPLAY_CONNECTION_TYPE_INTERNAL)
                    .Build());
 
-    screen_manager_->Init(&delegate_);
+    screen_manager_->Init(&delegate_, ScreenManager::WINDOW_MODE_INTERNAL);

[rjkroege, 2017/01/23 21:19:43]

This is not right in some fashion. One of the goals in this work is to use the
ozone wayland backend to support EXTERNAL window mode yes? So: the test should
be able to run with both INTERNAL and EXTERNAL? Right?

At a minimum: this needs a TODO() to say that the test should made to run with
external mode too?

[fwang, 2017/01/24 17:11:51]

I'll check that (BTW, note that this test is only executed on ChromeOS at the
moment and many other tests listed in this commit actually fails on non-ChromeOS
platforms).

     RunAllTasks();
 
     // Double check the expected display exists and clear counters.